Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(segment): disabled prop #1516

Merged
merged 5 commits into from
Jun 24, 2019
Merged

feat(segment): disabled prop #1516

merged 5 commits into from
Jun 24, 2019

Conversation

bmdalex
Copy link
Collaborator

@bmdalex bmdalex commented Jun 18, 2019

feat(segment): disabled prop

BREAKING CHANGES mitigation:

Segment's boxShadowColor variable was replaced by boxShadow => in order to set box shadow color you need to replace:

<Segment variables={{ boxShadowColor: COLOR }} />

with

<Segment variables={{ boxShadow: `1px 1px 1px 1px ${COLOR}` }} />

Description

For Segment component:

  • adds missing disabled prop
  • improves variables:
    • boxShadowColor variable was replaced by boxShadow
    • added colorDisabled, backgroundColorDisabled, borderColorDisabled, borderStyle, borderWidth

@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #1516 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1516      +/-   ##
==========================================
- Coverage   73.26%   73.21%   -0.05%     
==========================================
  Files         826      828       +2     
  Lines        6208     6212       +4     
  Branches     1778     1798      +20     
==========================================
  Hits         4548     4548              
- Misses       1655     1659       +4     
  Partials        5        5
Impacted Files Coverage Δ
...hemes/teams/components/Segment/segmentVariables.ts 33.33% <ø> (ø) ⬆️
packages/react/src/components/Segment/Segment.tsx 100% <ø> (ø) ⬆️
...gh-contrast/components/Segment/segmentVariables.ts 0% <0%> (ø)
...c/themes/teams/components/Segment/segmentStyles.ts 11.11% <0%> (-3.18%) ⬇️
.../teams-dark/components/Segment/segmentVariables.ts 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4e1772...3701d23. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
@bmdalex bmdalex merged commit 558a5f0 into master Jun 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/segment-disabled branch June 24, 2019 12:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧰 fix Introduces fix for broken behavior. 🚀 ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants