This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Dropdown): fix switch between multiple
and single
modes
#1830
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1658.
Fix 🔧
Previously, we had
value
in theDropdown
's state that conditionally can be single item or array of items. This PR performs normalization of values, so we will always deal with array of items. This allows to remove a lot of type casts and conditions.A code snippet to test