Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(Embed): get rid of white flash #1909

Merged
merged 18 commits into from
Sep 19, 2019
Merged

fix(Embed): get rid of white flash #1909

merged 18 commits into from
Sep 19, 2019

Conversation

lucivpav
Copy link
Contributor

Now, when you activate a video or iframe Embed, no white flash appears. Instead, the placeholder image is used.

Fixes #1586

@vercel vercel bot temporarily deployed to staging September 10, 2019 09:11 Inactive
@codecov
Copy link

codecov bot commented Sep 10, 2019

Codecov Report

Merging #1909 into master will decrease coverage by 0.04%.
The diff coverage is 55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1909      +/-   ##
==========================================
- Coverage    70.4%   70.35%   -0.05%     
==========================================
  Files         892      892              
  Lines        7870     7884      +14     
  Branches     2298     2305       +7     
==========================================
+ Hits         5541     5547       +6     
- Misses       2316     2324       +8     
  Partials       13       13
Impacted Files Coverage Δ
...t/src/themes/teams/components/Embed/embedStyles.ts 0% <0%> (ø) ⬆️
packages/react/src/components/Embed/Embed.tsx 77.77% <61.11%> (-17.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0350ae1...6e7de0d. Read the comment docs.

@vercel vercel bot temporarily deployed to staging September 17, 2019 15:53 Inactive
@vercel vercel bot temporarily deployed to staging September 18, 2019 13:24 Inactive
@vercel vercel bot temporarily deployed to staging September 19, 2019 12:48 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧰 fix Introduces fix for broken behavior. 🚀 ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embed video has a white flash when toggle active state
2 participants