This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
feat(icon): export bell-slash
and bell-snooze
icon
#1921
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
musingh1
commented
Sep 11, 2019
•
edited
Loading
edited
musingh1
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
September 11, 2019 19:29
musingh1
changed the title
Adding snooze icon and exporting bell-mute icon
feat(icon): export Sep 11, 2019
bell-mute
and snooze
icon
…ature/mukul/add-mute-unmute-icons
…com/stardust-ui/react into feature/mukul/add-mute-unmute-icons
Codecov Report
@@ Coverage Diff @@
## master #1921 +/- ##
==========================================
+ Coverage 69.98% 69.99% +0.01%
==========================================
Files 895 898 +3
Lines 7815 7818 +3
Branches 2281 2281
==========================================
+ Hits 5469 5472 +3
Misses 2336 2336
Partials 10 10
Continue to review full report at Codecov.
|
codepretty
reviewed
Sep 11, 2019
packages/react/src/themes/teams/components/Icon/svg/icons/index.ts
Outdated
Show resolved
Hide resolved
codepretty
reviewed
Sep 11, 2019
packages/react/src/themes/teams/components/Icon/svg/icons/index.ts
Outdated
Show resolved
Hide resolved
codepretty
approved these changes
Sep 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - please just update the names of the icons before checking in! :)
notandrew
reviewed
Sep 11, 2019
packages/react/src/themes/teams/components/Icon/svg/ProcessedIcons/icons-snooze.tsx
Show resolved
Hide resolved
musingh1
changed the title
feat(icon): export
feat(icon): export Sep 11, 2019
bell-mute
and snooze
iconbell-slash
and bell-snooze
icon
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.