This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
feat(prototypes): add prototype for custom scrollbar for menu, dialog, popup and list #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurokapsiar
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
September 24, 2019 05:32
Codecov Report
@@ Coverage Diff @@
## master #1962 +/- ##
=======================================
Coverage 76.71% 76.71%
=======================================
Files 160 160
Lines 5492 5492
Branches 1603 1585 -18
=======================================
Hits 4213 4213
Misses 1266 1266
Partials 13 13 Continue to review full report at Codecov.
|
jurokapsiar
added
🚀 ready for review
and removed
RFC
help wanted
Extra attention is needed
labels
Oct 1, 2019
layershifter
reviewed
Oct 4, 2019
layershifter
reviewed
Oct 4, 2019
layershifter
reviewed
Oct 4, 2019
layershifter
reviewed
Oct 4, 2019
layershifter
reviewed
Oct 4, 2019
layershifter
reviewed
Oct 4, 2019
layershifter
added
needs author changes
Author needs to implement changes before merge
🤖 prototype
and removed
🚀 ready for review
labels
Oct 4, 2019
Co-Authored-By: Oleksandr Fediashov <olfedias@microsoft.com>
Co-Authored-By: Oleksandr Fediashov <olfedias@microsoft.com>
Co-Authored-By: Oleksandr Fediashov <olfedias@microsoft.com>
Co-Authored-By: Oleksandr Fediashov <olfedias@microsoft.com>
jurokapsiar
added
🚀 ready for review
and removed
needs author changes
Author needs to implement changes before merge
labels
Oct 4, 2019
layershifter
changed the title
proto(Scroll): custom scrollbar for menu, dialog, popup and list
feat(prototypes): add custom scrollbar for menu, dialog, popup and list
Oct 4, 2019
layershifter
changed the title
feat(prototypes): add custom scrollbar for menu, dialog, popup and list
feat(prototypes): add prototype for custom scrollbar for menu, dialog, popup and list
Oct 4, 2019
layershifter
approved these changes
Oct 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prototype shows how to integrate Stardust components with react-custom-toolbar.
content
slot needs to have explicitwidth