Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(prototypes): add prototype for custom scrollbar for menu, dialog, popup and list #1962

Merged
merged 18 commits into from
Oct 17, 2019

Conversation

jurokapsiar
Copy link
Contributor

@jurokapsiar jurokapsiar commented Sep 24, 2019

This prototype shows how to integrate Stardust components with react-custom-toolbar.

  • Menu / submenu - works
  • Popup and Dialog - content slot needs to have explicit width
  • List - works
  • Dropdown - will need followup item

@codecov
Copy link

codecov bot commented Sep 24, 2019

Codecov Report

Merging #1962 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1962   +/-   ##
=======================================
  Coverage   76.71%   76.71%           
=======================================
  Files         160      160           
  Lines        5492     5492           
  Branches     1603     1585   -18     
=======================================
  Hits         4213     4213           
  Misses       1266     1266           
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db0932f...bc63595. Read the comment docs.

@layershifter layershifter added needs author changes Author needs to implement changes before merge 🤖 prototype and removed 🚀 ready for review labels Oct 4, 2019
Co-Authored-By: Oleksandr Fediashov <olfedias@microsoft.com>
@vercel vercel bot temporarily deployed to staging October 4, 2019 12:42 Inactive
Co-Authored-By: Oleksandr Fediashov <olfedias@microsoft.com>
@vercel vercel bot temporarily deployed to staging October 4, 2019 12:43 Inactive
jurokapsiar and others added 2 commits October 4, 2019 14:43
Co-Authored-By: Oleksandr Fediashov <olfedias@microsoft.com>
Co-Authored-By: Oleksandr Fediashov <olfedias@microsoft.com>
@vercel vercel bot temporarily deployed to staging October 4, 2019 12:43 Inactive
@vercel vercel bot temporarily deployed to staging October 4, 2019 12:43 Inactive
@vercel vercel bot temporarily deployed to staging October 4, 2019 12:46 Inactive
@jurokapsiar jurokapsiar added 🚀 ready for review and removed needs author changes Author needs to implement changes before merge labels Oct 4, 2019
@layershifter layershifter changed the title proto(Scroll): custom scrollbar for menu, dialog, popup and list feat(prototypes): add custom scrollbar for menu, dialog, popup and list Oct 4, 2019
@layershifter layershifter changed the title feat(prototypes): add custom scrollbar for menu, dialog, popup and list feat(prototypes): add prototype for custom scrollbar for menu, dialog, popup and list Oct 4, 2019
@jurokapsiar jurokapsiar merged commit bd5c78b into master Oct 17, 2019
@jurokapsiar jurokapsiar deleted the proto/custom-scroll branch October 17, 2019 19:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants