This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix: allow string or number as Input value #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
requested review from
dvdzkwsk,
kuzhelov,
miroslavstastny and
mnajdova
as code owners
levithomason
force-pushed
the
fix/input-default-value
branch
from
2c24efc
to
21be2e1
Compare
mnajdova
approved these changes
Sep 19, 2018
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
=======================================
Coverage 92.15% 92.15%
=======================================
Files 61 61
Lines 1058 1058
Branches 135 155 +20
=======================================
Hits 975 975
Misses 80 80
Partials 3 3
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Input typings currently only allow strings as value and defaultValue. This PR also allows numbers.