-
Notifications
You must be signed in to change notification settings - Fork 55
feat(list): enter and spacebar keyboard handling for List and Listitem #279
Conversation
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
========================================
+ Coverage 87.96% 89% +1.03%
========================================
Files 42 41 -1
Lines 1404 1391 -13
Branches 183 202 +19
========================================
+ Hits 1235 1238 +3
+ Misses 165 149 -16
Partials 4 4
Continue to review full report at Codecov.
|
src/lib/accessibility/Behaviors/List/SelectableListItemBehavior.ts
Outdated
Show resolved
Hide resolved
When I tried to navigate into the list with Figure out that it causing the role='presentation' which is generated on the div about the list. Find out if JAWS user navigate to listbox with virtual cursor, then need to press space activate navigation in listbox: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some NITs, we need to resolve merge conflicts there and ship it 👍
Generated by 🚫 dangerJS |
This PR adds focus zone and Enter/Space keyboard handlers to selection list.