-
Notifications
You must be signed in to change notification settings - Fork 55
fix(Icon): Color & docs update for Teams theme #384
Conversation
Codecov Report
@@ Coverage Diff @@
## master #384 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 41 41
Lines 1341 1341
Branches 172 172
=======================================
Hits 1230 1230
Misses 107 107
Partials 4 4 Continue to review full report at Codecov.
|
docs/src/examples/components/Icon/Usage/IconButtonExample.shorthand.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, see comments. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets, please, agree on the example provided before merging these changes - other than that am totally for merging it 👍
…add this as a Usage example in the Button component in a future PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, update the CHANGELOG before merge - thanks!
… dealing with spacing/padding
…t-ui/react into feat/icon-color-redlines
Updating the color for icon Teams theme.. An icon will inherit the current color of the font unless a new color is explicitly passed to icon.
Added new Color section to the doc site under Variations