This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
feat(rtl): add span element with dir: 'auto' for the strings used in the Stardust components #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-added examples in the Button and Header component
mnajdova
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
miroslavstastny
as code owners
January 11, 2019 14:13
mnajdova
changed the title
feat(chore): replace string content with Text component in all Stardust components
feat(Text): replace string content with Text component in all Stardust components
Jan 11, 2019
mnajdova
added
the
question
Further information is requested, concerns that require additional thought are raised
label
Jan 11, 2019
bmdalex
approved these changes
Jan 11, 2019
…is string -reverted changes in the other components that were using the Slot component
-refactored components to use the rtlProps
mnajdova
changed the title
feat(Text): replace string content with Text component in all Stardust components
feat(renderComponent): add dir: 'auto' in the components' root if the children or content is plain string
Jan 14, 2019
mnajdova
added
🚀 ready for review
and removed
question
Further information is requested, concerns that require additional thought are raised
🚧 WIP
labels
Jan 14, 2019
kuzhelov
approved these changes
Jan 21, 2019
@jurokapsiar thanks for the explanation, it is fixed now. Please take a look. |
-exported children dependent rtl attributes
kuzhelov
reviewed
Jan 21, 2019
kuzhelov
reviewed
Jan 21, 2019
kuzhelov
reviewed
Jan 21, 2019
kuzhelov
reviewed
Jan 21, 2019
kuzhelov
reviewed
Jan 21, 2019
# Conflicts: # CHANGELOG.md # src/components/Accordion/AccordionTitle.tsx # src/components/Menu/Menu.tsx # src/components/Menu/MenuItem.tsx
kuzhelov
reviewed
Jan 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have left couple comments - could we discuss them before merge?
kuzhelov
reviewed
Jan 22, 2019
# Conflicts: # CHANGELOG.md
kuzhelov
reviewed
Jan 22, 2019
kuzhelov
reviewed
Jan 22, 2019
kuzhelov
reviewed
Jan 22, 2019
kuzhelov
approved these changes
Jan 22, 2019
-updated changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the issues raised in the following #5 (comment)