This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(a11y): removed redundant a11y code from Dropdown #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviuaavram
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
approved these changes
Jan 25, 2019
mnajdova
approved these changes
Jan 25, 2019
|
nice cleanup. please make sure to have at least one example that shows how the messages can be provided by the consumer for translation purposes. |
jurokapsiar
added
the
needs author changes
silviuaavram
force-pushed
the
fix/remove-a11y-redundance
branch
from
63f2b2f
to
7a1c657
Compare
|
@jurokapsiar I've added an example in French. I wanted to be clear why those methods are needed for (internationalisation). |
silviuaavram
removed
the
needs author changes
|
Cette liste déroulante est fabuleuse! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup getA11yStatusMessage and A11yStatusMessageOptions once updated versions get released in Downshift.
Now these messages are generated by default as a result of downshift-js/downshift#629