fix(List): handle onClick and onFocus on items correctly #779

layershifter · 2019-01-28T12:09:18Z

Fixes #680.

…stardust-ui/react into fix/list-onclick # Conflicts: # CHANGELOG.md

layershifter · 2019-01-30T10:04:07Z

src/components/List/ListItem.tsx

@@ -85,6 +86,7 @@ class ListItem extends UIComponent<ReactProps<ListItemProps>, ListItemState> {
    media: PropTypes.any,

    selectable: PropTypes.bool,
+    index: PropTypes.number,


Actually, Menu does the same thing

miroslavstastny · 2019-01-30T10:31:00Z

test/specs/components/List/List-test.tsx

+        .first()
+        .simulate('click')
+
+      expect(onClick).toHaveBeenCalled()


Don't you want to check cb params as well?

fix(List): handle onClick and onFocus on items correctly

d3a440a

layershifter requested review from dvdzkwsk, kuzhelov, levithomason, miroslavstastny and mnajdova as code owners January 28, 2019 12:09

add changelog entry

14e40ba

layershifter added 🚀 ready for review 🧰 fix Introduces fix for broken behavior. labels Jan 30, 2019

layershifter added 2 commits January 30, 2019 11:13

Merge branches 'fix/list-onclick' and 'master' of https://github.com/…

11361e3

…stardust-ui/react into fix/list-onclick # Conflicts: # CHANGELOG.md

update UTs

abf006c

layershifter commented Jan 30, 2019

View reviewed changes

miroslavstastny approved these changes Jan 30, 2019

View reviewed changes

add more checks

b41ed44

layershifter merged commit 5d1ad21 into master Jan 30, 2019

layershifter deleted the fix/list-onclick branch January 30, 2019 11:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(List): handle onClick and onFocus on items correctly #779

fix(List): handle onClick and onFocus on items correctly #779

layershifter commented Jan 28, 2019

layershifter Jan 30, 2019

miroslavstastny Jan 30, 2019

layershifter Jan 30, 2019

fix(List): handle onClick and onFocus on items correctly #779

fix(List): handle onClick and onFocus on items correctly #779

Conversation

layershifter commented Jan 28, 2019

layershifter Jan 30, 2019

Choose a reason for hiding this comment

miroslavstastny Jan 30, 2019

Choose a reason for hiding this comment

layershifter Jan 30, 2019

Choose a reason for hiding this comment