This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(theming): exporting slot's classNames form components #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
miroslavstastny
as code owners
mnajdova
commented
Feb 1, 2019
src/components/Layout/Layout.tsx
Outdated
| startArea && 'ui-layout--reduced__start', | ||
| mainArea && 'ui-layout--reduced__main', | ||
| endArea && 'ui-layout--reduced__end', | ||
| startArea && Layout.slotClassNames.reducedStart, |
There was a problem hiding this comment.
Not sure if this is the right convention, as the className here is changed because of a prop...
mnajdova
commented
Feb 1, 2019
| @@ -175,8 +187,8 @@ class ItemLayout extends UIComponent<ReactProps<ItemLayoutProps>, any> { | |||
| const mainArea = renderMainArea(this.props, this.state, classes) | |||
| const endArea = endMedia | |||
|
|
|||
| const mergedMediaClasses = cx('ui-item-layout__media', classes.media) | |||
There was a problem hiding this comment.
Ups, breaking changes introduced. It seems that the classNames of this slots were not correct...
mnajdova
added
the
question
Codecov Report
@@ Coverage Diff @@
## master #827 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 21 21
Lines 728 728
Branches 73 73
=======================================
Hits 681 681
Misses 47 47Continue to review full report at Codecov.
|
silviuaavram
approved these changes
Feb 4, 2019
mnajdova
added
🚀 ready for review
and removed
question
kuzhelov
reviewed
Feb 4, 2019
CHANGELOG.md
Outdated
| @@ -17,8 +17,12 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ### BREAKING CHANGES | |||
| - Renamed classNames for the slots inside the `ItemLayout` component @mnajdova ([#827](https://github.com/stardust-ui/react/pull/827)) | |||
There was a problem hiding this comment.
lets do either 'class names' or 'classNames'. I would suggest the first option, as it is more correct and implementation agnostic :)
kuzhelov
reviewed
Feb 4, 2019
CHANGELOG.md
Outdated
| ### Features | ||
| - Accessibility for menu divider @jurokapsiar ([#822](https://github.com/stardust-ui/react/pull/822)) | ||
| - Added slotClassNames in `ChatMessage`, `ChatItem`, `Dropdown`, `ItemLayout`, `Layout`, `MenuItem` @mnajdova ([#827](https://github.com/stardust-ui/react/pull/827)) |
There was a problem hiding this comment.
would suggest just 'slot class names'
kuzhelov
approved these changes
Feb 4, 2019
added 2 commits
February 4, 2019 16:25
# Conflicts: # CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #784 by adding slotClassNames static fields int he component which have already specified some custom classNames for the slots.
BREAKING CHANGES
The classNames for the slots in the ItemLayout component have been renamed. Please replace the following selectors accordingly:
Question
Do we want to introduce slot's classes for the slots inside the component which are created with the Box or Text component? It seems reasonable to me, as these components can be heavily used in the content of the components, so selecting the slot's containers might be tricky... On the other hand, they can be styled via the slot's inside the component styles, but still creating selectors for them if necessary can be tricky.. Let me know what you think!
Decision
We will add them if there is requirement from the users.