-
Notifications
You must be signed in to change notification settings - Fork 55
feat(dropdown): single search #839
feat(dropdown): single search #839
Conversation
Codecov Report
@@ Coverage Diff @@
## master #839 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 21 21
Lines 728 728
Branches 73 73
=======================================
Hits 681 681
Misses 47 47 Continue to review full report at Codecov.
|
docs/src/examples/components/Dropdown/Types/DropdownExampleMultipleSelection.shorthand.tsx
Outdated
Show resolved
Hide resolved
docs/src/examples/components/Dropdown/Types/DropdownExampleMultipleSelection.shorthand.tsx
Outdated
Show resolved
Hide resolved
docs/src/examples/components/Dropdown/Types/DropdownExampleSingleSearch.shorthand.tsx
Outdated
Show resolved
Hide resolved
docs/src/examples/components/Dropdown/Types/DropdownExampleSingleSearch.shorthand.tsx
Outdated
Show resolved
Hide resolved
8509875
to
0e3890c
Compare
b4697b9
to
29e2582
Compare
I don't like the fact that if I want to replace the selected item I have to remove everything and start typing. I like the SUIR implementation: https://react.semantic-ui.com/modules/dropdown/#types-search-selection it's closer to what i would expect. If you have something selected and you are clicking again on the dropdown, clear the dropdown so that the user can start typing the new item. Does not have to be implemented as part of this PR, but this is something I had to mention :) |
docs/src/examples/components/Dropdown/Types/DropdownExampleSingleSelection.shorthand.steps.ts
Outdated
Show resolved
Hide resolved
29e2582
to
7c58355
Compare
We're actually following ARIA standards in this implementation: https://www.w3.org/TR/wai-aria-practices/examples/combobox/aria1.1pattern/listbox-combo.html I agree there should be a better way to clear the selection. The UX will get better when we'll be adding the 'x' icon to clear the selection. It's on the roadmap for Dropdown |
7c58355
to
b703b60
Compare
b703b60
to
927f132
Compare
927f132
to
6bc487e
Compare
docs/src/examples/components/Dropdown/State/DropdownExampleLoading.shorthand.tsx
Show resolved
Hide resolved
6bc487e
to
e21e1b4
Compare
feat(dropdown): single search
Description:
This PR implements the single selection with search flavor
Dropdown
component (prerequisite forinline
Dropdown
).API
renders: