This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
feat(Dropdown): arrow navigation between selected items #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviuaavram
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
February 5, 2019 10:55
silviuaavram
force-pushed
the
feat/dropdown-arrow-navigation
branch
from
February 5, 2019 10:57
981e6a0
to
75f9add
Compare
jurokapsiar
reviewed
Feb 6, 2019
jurokapsiar
reviewed
Feb 6, 2019
jurokapsiar
reviewed
Feb 6, 2019
silviuaavram
force-pushed
the
feat/dropdown-arrow-navigation
branch
from
February 6, 2019 11:17
acf7231
to
d0c8d65
Compare
Codecov Report
@@ Coverage Diff @@
## master #842 +/- ##
=======================================
Coverage 92.99% 92.99%
=======================================
Files 21 21
Lines 728 728
Branches 73 73
=======================================
Hits 677 677
Misses 51 51 Continue to review full report at Codecov.
|
bmdalex
reviewed
Feb 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@silviuavram - generally looks good, one thing: as we discussed, we'd like have the key nav extracted in the behaviors, can you create an issue or if it already exists reference it in this PR? Thanks!
silviuaavram
force-pushed
the
feat/dropdown-arrow-navigation
branch
2 times, most recently
from
February 7, 2019 09:22
67f6473
to
04005d3
Compare
sophieH29
reviewed
Feb 7, 2019
silviuaavram
force-pushed
the
feat/dropdown-arrow-navigation
branch
from
February 8, 2019 10:16
07622b3
to
b0a78d8
Compare
silviuaavram
force-pushed
the
feat/dropdown-arrow-navigation
branch
from
February 8, 2019 12:54
d639b66
to
887d940
Compare
bmdalex
approved these changes
Feb 8, 2019
mnajdova
reviewed
Feb 8, 2019
mnajdova
reviewed
Feb 8, 2019
jurokapsiar
approved these changes
Feb 8, 2019
mnajdova
reviewed
Feb 8, 2019
mnajdova
approved these changes
Feb 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the navigation between Dropdown selected items using the Arrow Left and Arrow Right keys. Dropdown must be a multiple selection.
Removed the
tabIndex=0
fromLabel
as it was not needed for click. @mnajdova please confirm. As a result, 'X' icons are no longer in the tab order, they can only be clicked in order to remove the item. Focus is returned to the search input at removal.Selected items are focusable now, but are not part of the normal tab order. Can be focused by click or by left/right arrow keys.
Added a style similar to Teams to the focused item (background colour change).
May need to rename
activeIndex
as I used it for consistency with Accordion/Menu but it may be a bit confusing, accepting feedback.Adding screener test to check highlighted style on both keydown and click.