-
Notifications
You must be signed in to change notification settings - Fork 55
feat(Label): added black and white colors for the color prop #855
Conversation
Codecov Report
@@ Coverage Diff @@
## master #855 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 21 21
Lines 728 728
Branches 69 69
=======================================
Hits 681 681
Misses 47 47 Continue to review full report at Codecov.
|
-added Breaking change entry in changelog
Are you going to update the references to the old |
@codepretty as far as I see in |
ah, i see. i missed the update to siteVariables you did to reference colors.grey[900]. do you think it will be confusing to devs using this to know that siteVars.black is different from colors.black without digging in? |
Yep, totally agree with the confusion, but will address this in a separate PR because I want this one to be simple. The basic idea I have in mind is that we should remove all colors we have in siteVariables, and use only the ones from the colors object. We will map all current color in the siteVariables with the corresponding matching from the colors object. As you may guess this will be a big change, and we need to keep in mind to create colors and scheme for the other themes as well (dark and HOC), so that theme switching would work as expected. |
Co-Authored-By: mnajdova <mnajdova@gmail.com>
This PR adds the black and white color options for the Label, in order to fix #739
Here is how all the variants for color look:
As the white and black are primitive colors, the color scheme for these colors is manually defined:
If there are any other ideas, please let me know.
BREAKING CHANGES (Teams theme)
The value for the
siteVariables.colors.black
was changed from thegrey[900](#252424)
variant to#000
. If there are usages of this variable, replaced them in the following manner:siteVariables.colors.black
<=>siteVariables.colors.grey[900]
Whenever you want to use the black color
(#000)
use the variablesiteVariables.colors.black
.