-
Notifications
You must be signed in to change notification settings - Fork 55
fix: (menu & menuitem): vertical menu theming updates #934
Conversation
d075365
to
75360c4
Compare
Codecov Report
@@ Coverage Diff @@
## master #934 +/- ##
==========================================
- Coverage 81.5% 81.45% -0.06%
==========================================
Files 673 673
Lines 8700 8708 +8
Branches 1541 1484 -57
==========================================
+ Hits 7091 7093 +2
- Misses 1594 1600 +6
Partials 15 15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice changes, some comments to address
packages/react/src/themes/teams-high-contrast/components/Menu/menuVariables.ts
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams-high-contrast/components/Menu/menuVariables.ts
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams-high-contrast/components/Menu/menuVariables.ts
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams-high-contrast/components/Menu/menuVariables.ts
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams-high-contrast/components/Menu/menuVariables.ts
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams/components/Menu/menuVariables.ts
Outdated
Show resolved
Hide resolved
75360c4
to
9575963
Compare
I found some time to take the branch and test it. It's true that the Dark and HC themes are much better, but we have a lot of regression on the general theme.. 1. wrong fonts for regular theme (
|
2dcfef2
to
b8db4b9
Compare
packages/react/src/themes/teams-dark/components/Menu/menuVariables.ts
Outdated
Show resolved
Hide resolved
Looks like the menu of the doc site was changed @levithomason do you know how @jaanus03 can exclude his changes from affecting the left rail menu? Update: chatted with @levithomason about this and he says it is fine to check in |
2a8a300
to
ddc06ee
Compare
packages/react/src/themes/teams/components/Menu/menuItemStyles.ts
Outdated
Show resolved
Hide resolved
eeaa3d0
to
26515d5
Compare
The aim of this this PR is to update vertical menu styles to make it look great again.
Current vertical menu styles:
New vertical menu styles: