This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Icons): Adding chevron down, download, email, search, star icon #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parasjindal
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #955 +/- ##
=========================================
- Coverage 80.72% 80.52% -0.2%
=========================================
Files 659 660 +1
Lines 8465 8453 -12
Branches 1495 1492 -3
=========================================
- Hits 6833 6807 -26
- Misses 1618 1631 +13
- Partials 14 15 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #955 +/- ##
==========================================
+ Coverage 80.5% 80.52% +0.01%
==========================================
Files 659 660 +1
Lines 8450 8453 +3
Branches 1493 1492 -1
==========================================
+ Hits 6803 6807 +4
+ Misses 1632 1631 -1
Partials 15 15
Continue to review full report at Codecov.
|
parasjindal
changed the title
parasjindal
changed the title
alinais
reviewed
Feb 25, 2019
codepretty
reviewed
Feb 25, 2019
| export default { | ||
| icon: ({ classes }) => ( | ||
| <svg role="presentation" focusable="false" viewBox="8 8 16 16" className={classes.svg}> | ||
| <g> |
There was a problem hiding this comment.
There's no harm in leaving it, but the g isn't necessary
codepretty
reviewed
Feb 25, 2019
| export default { | ||
| icon: ({ classes }) => ( | ||
| <svg role="presentation" focusable="false" viewBox="8 8 16 16" className={classes.svg}> | ||
| <g> |
There was a problem hiding this comment.
There's no harm in leaving it, but the g isn't necessary
There was a problem hiding this comment.
Same for all other svg files
added 3 commits
February 26, 2019 10:55
…jindal/export-icons
…l/react into pajindal/export-icons
codepretty
approved these changes
Feb 26, 2019
kuzhelov
approved these changes
Feb 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.