-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
Codecov Report
@@ Coverage Diff @@
## master #976 +/- ##
========================================
- Coverage 81.01% 81% -0.01%
========================================
Files 665 665
Lines 8527 8528 +1
Branches 1442 1443 +1
========================================
Hits 6908 6908
- Misses 1605 1606 +1
Partials 14 14
Continue to review full report at Codecov.
|
@@ -26,6 +27,7 @@ const avatarStyles: ComponentSlotStylesInput<AvatarProps, any> = { | |||
} | |||
}, | |||
image: ({ variables: v }): ICSSInJSStyle => ({ | |||
boxSizing: 'border-box', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that you added the same thing in the image, that would mean that we don't need i there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but this is, actually, necessary, as not only the Image
component could be rendered here. Essentially, we would like to ensure that all sizing props defined for this slot will be applied in the expected way
@@ -31,6 +31,7 @@ const radioStyles: ComponentSlotStylesInput< | |||
|
|||
icon: ({ props: p, variables: v }): ICSSInJSStyle => ({ | |||
margin: `0 ${pxToRem(10)} 0 0`, | |||
padding: 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused with this change... Can you explain what this was added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, have addressed related visual regression in icon's styles, thank you!
!! Important follow-up
Please, note that
box-sizing
issue is, essentially, the one that we might expect for other components to appear. This becomes to be an issue after static styles of Semantic UI were eliminated - one of the rules they had introduced wasbox-sizing
one.TODO
Appearance of Avatar component in Teams High Contrast theme was fixed. Specifically, the following
aspects were addressed:
Avatar sizing issue
When theme switch to Teams Hight Contrast (and, apart from other style changes,
border
being introduced to Avatar), Avatar's size was increased by border's thickness value:Teams default theme (size is 32px)
Teams High Contrast theme (size has changed to 32px + 2 * 2px)
This has happened because of absence of
box-sizing: border-box
CSS rule.Font-based
Icon
componentWhen is provided into
image
slot ofAvatar
component (originally reported here #795):Was
Now