abi parser Cario1 Version2 #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for starknetjs canceled.
|
penovicp
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
In general lgtm, there are some simple lint errors that will prevent the CI from running successfully so those should be resolved before merging.
ivpavici
reviewed
Jul 3, 2023
Yea, also this will be forced merged as it relays on integration |
ivpavici
approved these changes
Jul 3, 2023
|
🎉 This PR is included in version 5.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
# [5.17.0](v5.16.0...v5.17.0) (2023-07-18) ### Bug Fixes * add FailedTransactionResponse ([994925e](994925e)) * remedy type declaration roll-up issues ([48625f4](48625f4)) * transaction_failure_reason ([77329b7](77329b7)) ### Features * add Enum in contract ([515e233](515e233)), closes [#670](#670) [#665](#665) [#664](#664) [#1](#1) * calldata result in populate ([d44dc56](d44dc56)), closes [#675](#675) [#1](#1) * contractFactory Cairo1 & changed constructor signature, 0.12 test fixes ([9b44c54](9b44c54)) * rename Failed to Rejected for transaction type ([65b1ef4](65b1ef4))
github-actions bot
pushed a commit
that referenced
this pull request
Aug 11, 2023
# [5.19.0](v5.18.0...v5.19.0) (2023-08-11) ### Bug Fixes * add function definition to the contract interface + doc ([06498d5](06498d5)) * contract test status ([53cfaf9](53cfaf9)) * fix multiple same events + add cairo code + seperate tests, legacy and Cairo1 ([7c93157](7c93157)) * modify parseEvents structure + add testcase for multiple different event in same tx ([b63b0d6](b63b0d6)) * optional struct and enum in responseParser ([14d3cca](14d3cca)) * patch merge, and add enums to event parser ([00f8073](00f8073)) * remove exports from responseParser functions ([3d86446](3d86446)) * repair SequencerProvider network resolution ([e42dfc1](e42dfc1)) * restore package-lock to previous state ([2fe0564](2fe0564)) ### Features * add ethAddress handling ([2a93f90](2a93f90)) * cairo enum in request parser ([ad44481](ad44481)) * cairo enum in response parser ([a936a11](a936a11)), closes [#670](#670) [#665](#665) [#664](#664) [#1](#1) [#675](#675) [#1](#1) [#675](#675) [#1](#1) [#670](#670) [#665](#665) [#664](#664) [#1](#1) [#675](#675) [#1](#1) * implement event parsing ([86cc430](86cc430)) * new Cairo types ([f9db09e](f9db09e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
The quick implementation is only essential for parser v2, and will need to be refactored later
Tests for Cairo1 Version 2 - All expected to pass, pass (fail 2d array test on the same nonce issue)
create separate classes for abi parsing based on abi version true same interface and factory class.
extract existing parsing from implementations on CallData and Cairo into the parser.
Checklist: