-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V6] Implement RPC Batch #758
Comments
What will be the benefits for the user ? |
@PhilippeR26 I'm copying this proposal from Francesco: |
Are Starknet nodes already able to handle such batched requests?
Couldn't this be messy for our use case? and to be useful only for a batch of Read commands (not for Write command) ; for example 50 commands of getBlock()? So, I see an interest for a large batch of Calls, mainly getBlock(). I am rather anxious for other usage... |
I have found this interesting doc of Ethereum node Geth : https://geth.ethereum.org/docs/interacting-with-geth/rpc/batch |
Hi @tabaktoni , if this issue is still available i can work on it. Since Starknet nodes supports batch requests, it can be implemented rather easily. |
@ugur-eren sure, you can try |
To be honest i don't see the point as startknet provide multi call but, instead of user creating call array, it cold be done behind the scene. |
I agree, contract calls can be used with multicall, a simple function to batch requests can be implemented, for example unraggle.meme multiCallContract function. However adding batch would also enable batching for built-in methods, like |
🎉 This issue has been resolved in version 6.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hi @tabaktoni this issue is resolved with my PR #1125 can be closed. |
@ugur-eren reward sent! thanks!! |
Similar to Viem, time-based batch with config options.
Ref: #653
Viem docs: https://viem.sh/docs/clients/transports/http.html#batch-optional
The text was updated successfully, but these errors were encountered: