You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
As explained in the comment this method should not be part of the State trait.
It makes it weird to implement for any user of the lib. They now have to mirror your architecture otherwise they can't correctly impl the trait.
Can you please remove it from State and put it in another trait that may, or may not be implemented by the same structure?
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
blockifier/crates/blockifier/src/state/state_api.rs
Lines 106 to 109 in 1f54a54
As explained in the comment this method should not be part of the
State
trait.It makes it weird to implement for any user of the lib. They now have to mirror your architecture otherwise they can't correctly impl the trait.
Can you please remove it from
State
and put it in another trait that may, or may not be implemented by the same structure?The text was updated successfully, but these errors were encountered: