-
Notifications
You must be signed in to change notification settings - Fork 35
/
Copy pathaccount_transactions_test.rs
1845 lines (1700 loc) · 76.3 KB
/
account_transactions_test.rs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
use std::collections::{HashMap, HashSet};
use std::sync::Arc;
use cairo_vm::types::builtin_name::BuiltinName;
use cairo_vm::vm::runners::cairo_runner::ResourceTracker;
use num_traits::Inv;
use pretty_assertions::{assert_eq, assert_ne};
use rstest::rstest;
use starknet_api::abi::abi_utils::{
get_fee_token_var_address,
get_storage_var_address,
selector_from_name,
};
use starknet_api::block::{FeeType, GasPrice};
use starknet_api::core::{calculate_contract_address, ClassHash, ContractAddress};
use starknet_api::executable_transaction::{
AccountTransaction as ApiExecutableTransaction,
DeclareTransaction as ApiExecutableDeclareTransaction,
};
use starknet_api::execution_resources::GasAmount;
use starknet_api::hash::StarkHash;
use starknet_api::state::StorageKey;
use starknet_api::test_utils::invoke::InvokeTxArgs;
use starknet_api::test_utils::NonceManager;
use starknet_api::transaction::constants::TRANSFER_ENTRY_POINT_NAME;
use starknet_api::transaction::fields::{
AllResourceBounds,
Calldata,
ContractAddressSalt,
Fee,
GasVectorComputationMode,
Resource,
ResourceBounds,
ValidResourceBounds,
};
use starknet_api::transaction::{
DeclareTransaction,
DeclareTransactionV2,
TransactionHash,
TransactionVersion,
};
use starknet_api::{
calldata,
class_hash,
contract_address,
declare_tx_args,
deploy_account_tx_args,
felt,
invoke_tx_args,
nonce,
storage_key,
};
use starknet_types_core::felt::Felt;
use crate::check_tx_execution_error_for_invalid_scenario;
use crate::context::{BlockContext, TransactionContext};
use crate::execution::call_info::CallInfo;
use crate::execution::contract_class::TrackedResource;
use crate::execution::entry_point::EntryPointExecutionContext;
use crate::execution::syscalls::SyscallSelector;
use crate::fee::fee_utils::{get_fee_by_gas_vector, get_sequencer_balance_keys};
use crate::fee::gas_usage::estimate_minimal_gas_vector;
use crate::state::cached_state::{StateChangesCount, StateChangesCountForFee, TransactionalState};
use crate::state::state_api::{State, StateReader};
use crate::test_utils::contracts::FeatureContract;
use crate::test_utils::declare::declare_tx;
use crate::test_utils::deploy_account::deploy_account_tx;
use crate::test_utils::initial_test_state::{fund_account, test_state};
use crate::test_utils::invoke::invoke_tx;
use crate::test_utils::syscall::build_recurse_calldata;
use crate::test_utils::{
create_calldata,
create_trivial_calldata,
get_syscall_resources,
get_tx_resources,
CairoVersion,
CompilerBasedVersion,
BALANCE,
DEFAULT_L1_DATA_GAS_MAX_AMOUNT,
DEFAULT_L1_GAS_AMOUNT,
DEFAULT_L2_GAS_MAX_AMOUNT,
DEFAULT_STRK_L1_DATA_GAS_PRICE,
DEFAULT_STRK_L1_GAS_PRICE,
DEFAULT_STRK_L2_GAS_PRICE,
MAX_FEE,
};
use crate::transaction::account_transaction::{
AccountTransaction,
ExecutionFlags as AccountExecutionFlags,
};
use crate::transaction::objects::{HasRelatedFeeType, TransactionInfoCreator};
use crate::transaction::test_utils::{
account_invoke_tx,
all_resource_bounds,
block_context,
calculate_class_info_for_testing,
create_account_tx_for_validate_test_nonce_0,
create_all_resource_bounds,
create_test_init_data,
default_all_resource_bounds,
default_l1_resource_bounds,
deploy_and_fund_account,
l1_resource_bounds,
max_fee,
run_invoke_tx,
FaultyAccountTxCreatorArgs,
TestInitData,
INVALID,
};
use crate::transaction::transaction_types::TransactionType;
use crate::transaction::transactions::{enforce_fee, ExecutableTransaction, ExecutionFlags};
use crate::utils::u64_from_usize;
#[rstest]
fn test_circuit(block_context: BlockContext, default_all_resource_bounds: ValidResourceBounds) {
let test_contract = FeatureContract::TestContract(CairoVersion::Cairo1);
let account = FeatureContract::AccountWithoutValidations(CairoVersion::Cairo1);
let chain_info = &block_context.chain_info;
let state = &mut test_state(chain_info, BALANCE, &[(test_contract, 1), (account, 1)]);
let test_contract_address = test_contract.get_instance_address(0);
let account_address = account.get_instance_address(0);
let mut nonce_manager = NonceManager::default();
// Invoke a function that changes the state and reverts.
let tx_args = invoke_tx_args! {
sender_address: account_address,
calldata: create_calldata(
test_contract_address,
"test_circuit",
&[]
),
nonce: nonce_manager.next(account_address)
};
let tx_execution_info = run_invoke_tx(
state,
&block_context,
invoke_tx_args! {
resource_bounds: default_all_resource_bounds,
..tx_args
},
)
.unwrap();
assert!(tx_execution_info.revert_error.is_none());
}
#[rstest]
fn test_rc96_holes(block_context: BlockContext, default_all_resource_bounds: ValidResourceBounds) {
let test_contract = FeatureContract::TestContract(CairoVersion::Cairo1);
let account = FeatureContract::AccountWithoutValidations(CairoVersion::Cairo1);
let chain_info = &block_context.chain_info;
let state = &mut test_state(chain_info, BALANCE, &[(test_contract, 1), (account, 1)]);
let test_contract_address = test_contract.get_instance_address(0);
let account_address = account.get_instance_address(0);
let mut nonce_manager = NonceManager::default();
// Invoke a function that changes the state and reverts.
let tx_args = invoke_tx_args! {
sender_address: account_address,
calldata: create_calldata(
test_contract_address,
"test_rc96_holes",
&[]
),
nonce: nonce_manager.next(account_address)
};
let tx_execution_info = run_invoke_tx(
state,
&block_context,
invoke_tx_args! {
resource_bounds: default_all_resource_bounds,
..tx_args
},
)
.unwrap();
assert!(!tx_execution_info.is_reverted());
assert_eq!(
tx_execution_info.receipt.resources.computation.vm_resources.builtin_instance_counter
[&BuiltinName::range_check96],
24
);
}
#[rstest]
#[case::deprecated_tx(TransactionVersion::ONE, GasVectorComputationMode::NoL2Gas)]
#[case::l1_bounds(TransactionVersion::THREE, GasVectorComputationMode::NoL2Gas)]
#[case::all_bounds(TransactionVersion::THREE, GasVectorComputationMode::All)]
fn test_fee_enforcement(
block_context: BlockContext,
#[case] version: TransactionVersion,
#[case] gas_bounds_mode: GasVectorComputationMode,
#[values(true, false)] zero_bounds: bool,
) {
let account = FeatureContract::AccountWithoutValidations(CairoVersion::Cairo0);
let state = &mut test_state(&block_context.chain_info, BALANCE, &[(account, 1)]);
let tx = deploy_account_tx(
deploy_account_tx_args! {
class_hash: account.get_class_hash(),
max_fee: Fee(if zero_bounds { 0 } else { MAX_FEE.0 }),
resource_bounds: match gas_bounds_mode {
GasVectorComputationMode::NoL2Gas => l1_resource_bounds(
(if zero_bounds { 0 } else { DEFAULT_L1_GAS_AMOUNT.0 }).into(),
DEFAULT_STRK_L1_GAS_PRICE.into()
),
GasVectorComputationMode::All => create_all_resource_bounds(
(if zero_bounds { 0 } else { DEFAULT_L1_GAS_AMOUNT.0 }).into(),
DEFAULT_STRK_L1_GAS_PRICE.into(),
(if zero_bounds { 0 } else { DEFAULT_L2_GAS_MAX_AMOUNT.0 }).into(),
DEFAULT_STRK_L2_GAS_PRICE.into(),
(if zero_bounds { 0 } else { DEFAULT_L1_DATA_GAS_MAX_AMOUNT.0 }).into(),
DEFAULT_STRK_L1_DATA_GAS_PRICE.into(),
),
},
version,
},
&mut NonceManager::default(),
);
let only_query = false;
let charge_fee = enforce_fee(&tx, only_query);
let execution_flags =
AccountExecutionFlags { only_query, charge_fee, ..AccountExecutionFlags::default() };
let deploy_account_tx = AccountTransaction { tx, execution_flags };
let enforce_fee = deploy_account_tx.enforce_fee();
assert_ne!(zero_bounds, enforce_fee);
let result = deploy_account_tx.execute(state, &block_context);
// Execution should fail if the fee is enforced because the account doesn't have sufficient
// balance.
assert_eq!(result.is_err(), enforce_fee);
}
#[rstest]
fn test_all_bounds_combinations_enforce_fee(
#[values(0, 1)] l1_gas_bound: u64,
#[values(0, 1)] l1_data_gas_bound: u64,
#[values(0, 1)] l2_gas_bound: u64,
) {
let expected_enforce_fee = l1_gas_bound + l1_data_gas_bound + l2_gas_bound > 0;
let account_tx = account_invoke_tx(invoke_tx_args! {
version: TransactionVersion::THREE,
resource_bounds: create_all_resource_bounds(
l1_gas_bound.into(),
DEFAULT_STRK_L1_GAS_PRICE.into(),
l2_gas_bound.into(),
DEFAULT_STRK_L2_GAS_PRICE.into(),
l1_data_gas_bound.into(),
DEFAULT_STRK_L1_DATA_GAS_PRICE.into(),
),
});
assert_eq!(account_tx.enforce_fee(), expected_enforce_fee);
}
#[rstest]
#[case::positive_case_deprecated_tx(true, true)]
#[case::positive_case_new_tx(true, false)]
#[should_panic(expected = "exceeded bounds; max fee is")]
#[case::negative_case_deprecated_tx(false, true)]
#[should_panic(expected = "exceeded bounds; max possible fee is")]
#[case::negative_case_new_tx(false, false)]
fn test_assert_actual_fee_in_bounds(
block_context: BlockContext,
#[case] positive_flow: bool,
#[case] deprecated_tx: bool,
) {
let actual_fee_offset = Fee(if positive_flow { 0 } else { 1 });
if deprecated_tx {
let max_fee = Fee(100);
let tx = account_invoke_tx(invoke_tx_args! { max_fee, version: TransactionVersion::ONE });
let context = Arc::new(block_context.to_tx_context(&tx));
AccountTransaction::assert_actual_fee_in_bounds(&context, max_fee + actual_fee_offset);
} else {
// All resources.
let l1_gas = ResourceBounds { max_amount: GasAmount(2), max_price_per_unit: GasPrice(3) };
let l2_gas = ResourceBounds { max_amount: GasAmount(4), max_price_per_unit: GasPrice(5) };
let l1_data_gas =
ResourceBounds { max_amount: GasAmount(6), max_price_per_unit: GasPrice(7) };
let all_resource_bounds =
ValidResourceBounds::AllResources(AllResourceBounds { l1_gas, l2_gas, l1_data_gas });
let all_resource_fee = l1_gas.max_amount.checked_mul(l1_gas.max_price_per_unit).unwrap()
+ l2_gas.max_amount.checked_mul(l2_gas.max_price_per_unit).unwrap()
+ l1_data_gas.max_amount.checked_mul(l1_data_gas.max_price_per_unit).unwrap()
+ actual_fee_offset;
// L1 resources.
let l1_resource_bounds = ValidResourceBounds::L1Gas(l1_gas);
let l1_resource_fee =
l1_gas.max_amount.checked_mul(l1_gas.max_price_per_unit).unwrap() + actual_fee_offset;
for (bounds, actual_fee) in
[(all_resource_bounds, all_resource_fee), (l1_resource_bounds, l1_resource_fee)]
{
let tx = account_invoke_tx(invoke_tx_args! {
resource_bounds: bounds,
version: TransactionVersion::THREE,
});
let context = Arc::new(block_context.to_tx_context(&tx));
AccountTransaction::assert_actual_fee_in_bounds(&context, actual_fee);
}
}
}
// TODO(Dori, 15/9/2023): Convert version variance to attribute macro.
#[rstest]
#[case::v0(TransactionVersion::ZERO, default_all_resource_bounds())]
#[case::v1(TransactionVersion::ONE, default_all_resource_bounds())]
#[case::l1_bounds(TransactionVersion::THREE, default_l1_resource_bounds())]
#[case::all_bounds(TransactionVersion::THREE, default_all_resource_bounds())]
fn test_account_flow_test(
block_context: BlockContext,
max_fee: Fee,
#[case] tx_version: TransactionVersion,
#[case] resource_bounds: ValidResourceBounds,
#[values(true, false)] only_query: bool,
) {
let TestInitData { mut state, account_address, contract_address, mut nonce_manager } =
create_test_init_data(&block_context.chain_info, CairoVersion::Cairo0);
// Invoke a function from the newly deployed contract.
run_invoke_tx(
&mut state,
&block_context,
invoke_tx_args! {
max_fee,
sender_address: account_address,
calldata: create_trivial_calldata(contract_address),
version: tx_version,
resource_bounds,
nonce: nonce_manager.next(account_address),
only_query,
},
)
.unwrap();
}
#[rstest]
#[case(TransactionVersion::ZERO)]
#[case(TransactionVersion::ONE)]
#[case(TransactionVersion::THREE)]
fn test_invoke_tx_from_non_deployed_account(
block_context: BlockContext,
max_fee: Fee,
default_all_resource_bounds: ValidResourceBounds,
#[case] tx_version: TransactionVersion,
) {
let TestInitData { mut state, account_address, contract_address: _, mut nonce_manager } =
create_test_init_data(&block_context.chain_info, CairoVersion::Cairo0);
// Invoke a function from the newly deployed contract.
let entry_point_selector = selector_from_name("return_result");
let non_deployed_contract_address = StarkHash::TWO;
let tx_result = run_invoke_tx(
&mut state,
&block_context,
invoke_tx_args! {
max_fee,
sender_address: account_address,
calldata: calldata![
non_deployed_contract_address, // Contract address.
entry_point_selector.0, // EP selector.
felt!(1_u8), // Calldata length.
felt!(2_u8) // Calldata: num.
],
resource_bounds: default_all_resource_bounds,
version: tx_version,
nonce: nonce_manager.next(account_address),
},
);
let expected_error = "is not deployed.";
match tx_result {
Ok(info) => {
// Make sure the error is because the account wasn't deployed.
assert!(info.revert_error.unwrap().to_string().contains(expected_error));
}
Err(err) => {
// Make sure the error is because the account wasn't deployed.
assert!(err.to_string().contains(expected_error));
// We expect to get an error only when tx_version is 0, on other versions to revert.
assert_eq!(tx_version, TransactionVersion::ZERO);
}
}
}
#[rstest]
// Try two runs for each recursion type: one short run (success), and one that reverts due to step
// limit.
fn test_infinite_recursion(
#[values(true, false)] success: bool,
#[values(true, false)] normal_recurse: bool,
mut block_context: BlockContext,
#[values(default_l1_resource_bounds(), default_all_resource_bounds())]
resource_bounds: ValidResourceBounds,
) {
// Limit the number of execution steps (so we quickly hit the limit).
block_context.versioned_constants.invoke_tx_max_n_steps = 4200;
let TestInitData { mut state, account_address, contract_address, mut nonce_manager } =
create_test_init_data(&block_context.chain_info, CairoVersion::Cairo0);
let recursion_depth = if success { 3_u32 } else { 1000_u32 };
let execute_calldata = if normal_recurse {
create_calldata(contract_address, "recurse", &[felt!(recursion_depth)])
} else {
create_calldata(
contract_address,
"recursive_syscall",
&[
*contract_address.0.key(), // Calldata: raw contract address.
selector_from_name("recursive_syscall").0, // Calldata: raw selector
felt!(recursion_depth),
],
)
};
let tx_execution_info = run_invoke_tx(
&mut state,
&block_context,
invoke_tx_args! {
resource_bounds,
sender_address: account_address,
calldata: execute_calldata,
nonce: nonce_manager.next(account_address),
},
)
.unwrap();
if success {
assert!(tx_execution_info.revert_error.is_none());
} else {
assert!(
tx_execution_info
.revert_error
.unwrap()
.to_string()
.contains("RunResources has no remaining steps.")
);
}
}
/// Tests that validation fails on insufficient steps if max fee is too low.
#[rstest]
#[case::v1(TransactionVersion::ONE, default_l1_resource_bounds())]
#[case::v3_l1_bounds_only(TransactionVersion::THREE, default_l1_resource_bounds())]
#[case::v3_all_bounds(TransactionVersion::THREE, default_all_resource_bounds())]
fn test_max_fee_limit_validate(
mut block_context: BlockContext,
#[case] version: TransactionVersion,
#[case] resource_bounds: ValidResourceBounds,
#[values(true, false)] use_kzg_da: bool,
) {
block_context.block_info.use_kzg_da = use_kzg_da;
let chain_info = &block_context.chain_info;
let gas_computation_mode = resource_bounds.get_gas_vector_computation_mode();
let TestInitData { mut state, account_address, contract_address, mut nonce_manager } =
create_test_init_data(chain_info, CairoVersion::Cairo1);
let grindy_validate_account = FeatureContract::AccountWithLongValidate(CairoVersion::Cairo1);
let grindy_class_hash = grindy_validate_account.get_class_hash();
let block_info = &block_context.block_info;
let class_info = calculate_class_info_for_testing(grindy_validate_account.get_class());
// Declare the grindy-validation account.
let tx = declare_tx(
declare_tx_args! {
class_hash: grindy_class_hash,
sender_address: account_address,
resource_bounds,
nonce: nonce_manager.next(account_address),
},
class_info,
);
let execution_flags = AccountExecutionFlags::default();
let account_tx = AccountTransaction { tx, execution_flags };
account_tx.execute(&mut state, &block_context).unwrap();
// Deploy grindy account with a lot of grind in the constructor.
// Expect this to fail without bumping nonce, so pass a temporary nonce manager.
// We want to test the block step bounds here - so set them to something low.
let old_validate_max_n_steps = block_context.versioned_constants.validate_max_n_steps;
block_context.versioned_constants.validate_max_n_steps = 1000;
let mut ctor_grind_arg = felt!(1_u8); // Grind in deploy phase.
let ctor_storage_arg = felt!(1_u8); // Not relevant for this test.
let (deploy_account_tx, _) = deploy_and_fund_account(
&mut state,
&mut NonceManager::default(),
chain_info,
deploy_account_tx_args! {
class_hash: grindy_class_hash,
resource_bounds,
constructor_calldata: calldata![ctor_grind_arg, ctor_storage_arg],
},
);
let error_trace =
deploy_account_tx.execute(&mut state, &block_context).unwrap_err().to_string();
assert!(error_trace.contains("no remaining steps"));
block_context.versioned_constants.validate_max_n_steps = old_validate_max_n_steps;
// Deploy grindy account successfully this time.
ctor_grind_arg = felt!(0_u8); // Do not grind in deploy phase.
let (deploy_account_tx, grindy_account_address) = deploy_and_fund_account(
&mut state,
&mut nonce_manager,
chain_info,
deploy_account_tx_args! {
class_hash: grindy_class_hash,
resource_bounds,
constructor_calldata: calldata![ctor_grind_arg, ctor_storage_arg],
},
);
deploy_account_tx.execute(&mut state, &block_context).unwrap();
// Invoke a function that grinds validate (any function will do); set bounds low enough to fail
// on this grind.
// Only grind a small number of iterations (in the calldata) to ensure we are limited by the
// transaction bounds, and not the global block bounds.
// To ensure bounds are low enough, estimate minimal resources consumption, and set bounds
// slightly above them.
let tx_args = invoke_tx_args! {
sender_address: grindy_account_address,
calldata: create_calldata(contract_address, "return_result", &[1000_u32.into()]),
version,
nonce: nonce_manager.next(grindy_account_address)
};
let account_tx = account_invoke_tx(invoke_tx_args! {
// Temporary upper bounds; just for gas estimation.
max_fee: MAX_FEE,
resource_bounds,
..tx_args.clone()
});
let estimated_min_gas_usage_vector =
estimate_minimal_gas_vector(&block_context, &account_tx, &gas_computation_mode);
let estimated_min_fee =
get_fee_by_gas_vector(block_info, estimated_min_gas_usage_vector, &account_tx.fee_type());
// Make sure the resource bounds are the limiting factor by blowing up the block bounds.
let old_validate_max_n_steps = block_context.versioned_constants.validate_max_n_steps;
block_context.versioned_constants.validate_max_n_steps = u32::MAX;
let error_trace = run_invoke_tx(
&mut state,
&block_context,
invoke_tx_args! {
max_fee: estimated_min_fee,
resource_bounds: match resource_bounds.get_gas_vector_computation_mode() {
GasVectorComputationMode::NoL2Gas => {
// If KZG DA mode is active, the L1 gas amount in the minimal fee estimate does
// not include DA. To cover minimal cost with only an L1 gas bound, need to
// convert the L1 data gas to L1 gas.
let tx_context = TransactionContext {
block_context: block_context.clone(),
tx_info: account_tx.create_tx_info(),
};
let gas_prices = tx_context.get_gas_prices();
l1_resource_bounds(
estimated_min_gas_usage_vector.to_discounted_l1_gas(gas_prices),
gas_prices.l1_gas_price.into(),
)
}
GasVectorComputationMode::All => create_all_resource_bounds(
estimated_min_gas_usage_vector.l1_gas,
block_info.gas_prices
.l1_gas_price(&account_tx.fee_type()).into(),
estimated_min_gas_usage_vector.l2_gas,
block_info.gas_prices
.l2_gas_price(&account_tx.fee_type()).into(),
estimated_min_gas_usage_vector.l1_data_gas,
block_info.gas_prices
.l1_data_gas_price(&account_tx.fee_type()).into(),
),
},
..tx_args
},
)
.unwrap_err()
.to_string();
block_context.versioned_constants.validate_max_n_steps = old_validate_max_n_steps;
assert!(error_trace.contains("no remaining steps") | error_trace.contains("Out of gas"))
}
#[rstest]
#[case::v1(TransactionVersion::ONE, default_all_resource_bounds())]
#[case::l1_bounds(TransactionVersion::THREE, default_l1_resource_bounds())]
#[case::all_bounds(TransactionVersion::THREE, default_all_resource_bounds())]
fn test_recursion_depth_exceeded(
#[case] tx_version: TransactionVersion,
#[values(CairoVersion::Cairo0, CairoVersion::Cairo1)] cairo_version: CairoVersion,
block_context: BlockContext,
max_fee: Fee,
#[case] resource_bounds: ValidResourceBounds,
) {
let TestInitData { mut state, account_address, contract_address, mut nonce_manager } =
create_test_init_data(&block_context.chain_info, cairo_version);
// Positive test
// Technical details for this specific recursive entry point:
// The maximum inner recursion depth is reduced by 2 from the global entry point limit for two
// reasons:
// 1. An additional call is made initially before entering the recursion.
// 2. The base case for recursion occurs at depth 0, not at depth 1.
// TODO(Ori, 1/2/2024): Write an indicative expect message explaining why the conversion works.
let max_inner_recursion_depth: u8 = (block_context.versioned_constants.max_recursion_depth - 2)
.try_into()
.expect("Failed to convert usize to u8.");
let recursive_syscall_entry_point_name = "recursive_syscall";
let calldata = create_calldata(
contract_address,
recursive_syscall_entry_point_name,
&[
*contract_address.0.key(), // Calldata: raw contract address.
selector_from_name(recursive_syscall_entry_point_name).0, // Calldata: raw selector.
felt!(max_inner_recursion_depth),
],
);
let invoke_args = invoke_tx_args! {
max_fee,
sender_address: account_address,
calldata,
version: tx_version,
nonce: nonce_manager.next(account_address),
resource_bounds,
};
let tx_execution_info = run_invoke_tx(&mut state, &block_context, invoke_args.clone());
assert!(tx_execution_info.unwrap().revert_error.is_none());
// Negative test
let exceeding_recursion_depth = max_inner_recursion_depth + 1;
let calldata = create_calldata(
contract_address,
recursive_syscall_entry_point_name,
&[
*contract_address.0.key(), // Calldata: raw contract address.
selector_from_name(recursive_syscall_entry_point_name).0, // Calldata: raw selector.
felt!(exceeding_recursion_depth),
],
);
let invoke_args =
InvokeTxArgs { calldata, nonce: nonce_manager.next(account_address), ..invoke_args };
let tx_execution_info = run_invoke_tx(&mut state, &block_context, invoke_args);
assert!(
tx_execution_info
.unwrap()
.revert_error
.unwrap()
.to_string()
.contains("recursion depth exceeded")
);
}
#[rstest]
/// Tests that an account invoke transaction that fails the execution phase, still incurs a nonce
/// increase and a fee deduction.
#[case(TransactionVersion::ONE, FeeType::Eth)]
#[case(TransactionVersion::THREE, FeeType::Strk)]
fn test_revert_invoke(
block_context: BlockContext,
max_fee: Fee,
all_resource_bounds: ValidResourceBounds,
#[case] transaction_version: TransactionVersion,
#[case] fee_type: FeeType,
) {
let test_contract = FeatureContract::TestContract(CairoVersion::Cairo0);
let account = FeatureContract::AccountWithoutValidations(CairoVersion::Cairo0);
let chain_info = &block_context.chain_info;
let state = &mut test_state(chain_info, BALANCE, &[(test_contract, 1), (account, 1)]);
let test_contract_address = test_contract.get_instance_address(0);
let account_address = account.get_instance_address(0);
let mut nonce_manager = NonceManager::default();
// Invoke a function that changes the state and reverts.
let storage_key = felt!(9_u8);
let tx_execution_info = run_invoke_tx(
state,
&block_context,
invoke_tx_args! {
max_fee,
resource_bounds: all_resource_bounds,
sender_address: account_address,
calldata: create_calldata(
test_contract_address,
"write_and_revert",
// Write some non-zero value.
&[storage_key, felt!(99_u8)]
),
version: transaction_version,
nonce: nonce_manager.next(account_address),
},
)
.unwrap();
// TODO(Dori, 1/7/2023): Verify that the actual fee collected is exactly the fee computed for
// the validate and fee transfer calls.
// Check that the transaction was reverted.
assert!(tx_execution_info.revert_error.is_some());
// Check that the nonce was increased and the fee was deducted.
assert_eq!(
state
.get_fee_token_balance(account_address, chain_info.fee_token_address(&fee_type))
.unwrap(),
(felt!(BALANCE.0 - tx_execution_info.receipt.fee.0), felt!(0_u8))
);
assert_eq!(state.get_nonce_at(account_address).unwrap(), nonce_manager.next(account_address));
// Check that reverted steps are taken into account.
assert!(tx_execution_info.receipt.resources.computation.n_reverted_steps > 0);
// Check that execution state changes were reverted.
assert_eq!(
felt!(0_u8),
state
.get_storage_at(test_contract_address, StorageKey::try_from(storage_key).unwrap())
.unwrap()
);
}
#[rstest]
/// Tests that failing account deployment should not change state (no fee charge or nonce bump).
fn test_fail_deploy_account(
block_context: BlockContext,
#[values(CairoVersion::Cairo0, CairoVersion::Cairo1)] cairo_version: CairoVersion,
#[values(TransactionVersion::ONE, TransactionVersion::THREE)] tx_version: TransactionVersion,
) {
let chain_info = &block_context.chain_info;
let faulty_account_feature_contract = FeatureContract::FaultyAccount(cairo_version);
let state = &mut test_state(chain_info, BALANCE, &[(faulty_account_feature_contract, 0)]);
// Create and execute (failing) deploy account transaction.
let deploy_account_tx =
create_account_tx_for_validate_test_nonce_0(FaultyAccountTxCreatorArgs {
tx_type: TransactionType::DeployAccount,
tx_version,
scenario: INVALID,
class_hash: faulty_account_feature_contract.get_class_hash(),
max_fee: BALANCE,
resource_bounds: default_l1_resource_bounds(),
..Default::default()
});
let fee_token_address = chain_info.fee_token_address(&deploy_account_tx.fee_type());
let deploy_address = match &deploy_account_tx.tx {
ApiExecutableTransaction::DeployAccount(deploy_tx) => deploy_tx.contract_address(),
_ => unreachable!("deploy_account_tx is a DeployAccount"),
};
fund_account(chain_info, deploy_address, Fee(BALANCE.0 * 2), &mut state.state);
let initial_balance = state.get_fee_token_balance(deploy_address, fee_token_address).unwrap();
let error = deploy_account_tx.execute(state, &block_context).unwrap_err();
// Check the error is as expected. Assure the error message is not nonce or fee related.
check_tx_execution_error_for_invalid_scenario!(cairo_version, error, false);
// Assert nonce and balance are unchanged, and that no contract was deployed at the address.
assert_eq!(state.get_nonce_at(deploy_address).unwrap(), nonce!(0_u8));
assert_eq!(
state.get_fee_token_balance(deploy_address, fee_token_address).unwrap(),
initial_balance
);
assert_eq!(state.get_class_hash_at(deploy_address).unwrap(), ClassHash::default());
}
#[rstest]
/// Tests that a failing declare transaction should not change state (no fee charge or nonce bump).
fn test_fail_declare(block_context: BlockContext, max_fee: Fee) {
let chain_info = &block_context.chain_info;
let TestInitData { mut state, account_address, mut nonce_manager, .. } =
create_test_init_data(chain_info, CairoVersion::Cairo0);
let class_hash = class_hash!(0xdeadeadeaf72_u128);
let contract_class = FeatureContract::Empty(CairoVersion::Cairo1).get_class();
let next_nonce = nonce_manager.next(account_address);
// Cannot fail executing a declare tx unless it's V2 or above, and already declared.
let declare_tx_v2 = DeclareTransactionV2 {
max_fee,
class_hash,
sender_address: account_address,
..Default::default()
};
state.set_contract_class(class_hash, contract_class.clone().try_into().unwrap()).unwrap();
state.set_compiled_class_hash(class_hash, declare_tx_v2.compiled_class_hash).unwrap();
let class_info = calculate_class_info_for_testing(contract_class);
let executable_declare = ApiExecutableDeclareTransaction {
tx: DeclareTransaction::V2(DeclareTransactionV2 { nonce: next_nonce, ..declare_tx_v2 }),
tx_hash: TransactionHash::default(),
class_info,
};
let declare_account_tx = AccountTransaction {
tx: ApiExecutableTransaction::Declare(executable_declare),
execution_flags: AccountExecutionFlags::default(),
};
// Fail execution, assert nonce and balance are unchanged.
let tx_info = declare_account_tx.create_tx_info();
let initial_balance = state
.get_fee_token_balance(account_address, chain_info.fee_token_address(&tx_info.fee_type()))
.unwrap();
declare_account_tx.execute(&mut state, &block_context).unwrap_err();
assert_eq!(state.get_nonce_at(account_address).unwrap(), next_nonce);
assert_eq!(
state
.get_fee_token_balance(
account_address,
chain_info.fee_token_address(&tx_info.fee_type())
)
.unwrap(),
initial_balance
);
}
fn recursive_function_calldata(
contract_address: &ContractAddress,
depth: u32,
failure_variant: bool,
) -> Calldata {
create_calldata(
*contract_address,
if failure_variant { "recursive_fail" } else { "recurse" },
&[felt!(depth)], // Calldata: recursion depth.
)
}
#[rstest]
/// Tests that reverted transactions are charged more fee and steps than their (recursive) prefix
/// successful counterparts.
/// In this test reverted transactions are valid function calls that got insufficient steps limit.
#[case::v1(TransactionVersion::ONE, default_all_resource_bounds())]
#[case::l1_bounds(TransactionVersion::THREE, default_l1_resource_bounds())]
#[case::all_bounds(TransactionVersion::THREE, default_all_resource_bounds())]
fn test_reverted_reach_steps_limit(
max_fee: Fee,
mut block_context: BlockContext,
#[case] version: TransactionVersion,
#[case] resource_bounds: ValidResourceBounds,
#[values(CairoVersion::Cairo0, CairoVersion::Cairo1)] cairo_version: CairoVersion,
) {
let TestInitData { mut state, account_address, contract_address, mut nonce_manager } =
create_test_init_data(&block_context.chain_info, cairo_version);
// Limit the number of execution steps (so we quickly hit the limit).
block_context.versioned_constants.invoke_tx_max_n_steps = 6000;
let recursion_base_args = invoke_tx_args! {
max_fee,
resource_bounds,
sender_address: account_address,
version,
};
// Invoke the `recurse` function with 0 iterations. This call should succeed.
let result = run_invoke_tx(
&mut state,
&block_context,
invoke_tx_args! {
nonce: nonce_manager.next(account_address),
calldata: recursive_function_calldata(&contract_address, 0, false),
..recursion_base_args.clone()
},
)
.unwrap();
let n_steps_0 = result.receipt.resources.computation.total_charged_steps();
let actual_fee_0 = result.receipt.fee.0;
// Ensure the transaction was not reverted.
assert!(!result.is_reverted());
// Invoke the `recurse` function with 1 iteration. This call should succeed.
let result = run_invoke_tx(
&mut state,
&block_context,
invoke_tx_args! {
nonce: nonce_manager.next(account_address),
calldata: recursive_function_calldata(&contract_address, 1, false),
..recursion_base_args.clone()
},
)
.unwrap();
let n_steps_1 = result.receipt.resources.computation.total_charged_steps();
let actual_fee_1 = result.receipt.fee.0;
// Ensure the transaction was not reverted.
assert!(!result.is_reverted());
// Make sure that the n_steps and actual_fee are higher as the recursion depth increases.
assert!(n_steps_1 > n_steps_0);
assert!(actual_fee_1 > actual_fee_0);
// Calculate a recursion depth where the transaction will surely fail (not a minimal depth, as
// base costs are neglected here).
let steps_diff = n_steps_1 - n_steps_0;
// TODO(Ori, 1/2/2024): Write an indicative expect message explaining why the conversion works.
let steps_diff_as_u32: u32 = steps_diff.try_into().expect("Failed to convert usize to u32.");
let fail_depth = block_context.versioned_constants.invoke_tx_max_n_steps / steps_diff_as_u32;
// Invoke the `recurse` function with `fail_depth` iterations. This call should fail.
let result = run_invoke_tx(
&mut state,
&block_context,
invoke_tx_args! {
nonce: nonce_manager.next(account_address),
calldata: recursive_function_calldata(&contract_address, fail_depth, false),
..recursion_base_args.clone()
},
)
.unwrap();
let n_steps_fail = result.receipt.resources.computation.total_charged_steps();
let actual_fee_fail: u128 = result.receipt.fee.0;
// Ensure the transaction was reverted.
assert!(result.is_reverted());
// Make sure that the failed transaction gets charged for the extra steps taken, compared with
// the smaller valid transaction.
// If this fail, try to increase the `invoke_tx_max_n_steps` above.
assert!(n_steps_fail > n_steps_1);
assert!(actual_fee_fail > actual_fee_1);
// Invoke the `recurse` function with `fail_depth`+1 iterations. This call should fail.
let result = run_invoke_tx(
&mut state,
&block_context,
invoke_tx_args! {
nonce: nonce_manager.next(account_address),
calldata: recursive_function_calldata(&contract_address, fail_depth + 1, false),
..recursion_base_args
},
)
.unwrap();
let n_steps_fail_next = result.receipt.resources.computation.total_charged_steps();
let actual_fee_fail_next: u128 = result.receipt.fee.0;
// Ensure the transaction was reverted.
assert!(result.is_reverted());
// Test that the two reverted transactions behave the same.
assert!(n_steps_fail == n_steps_fail_next);
assert!(actual_fee_fail == actual_fee_fail_next);
}
#[rstest]
/// Tests that n_steps and actual_fees of reverted transactions invocations are consistent.
/// In this test reverted transactions are recursive function invocations where the innermost call
/// asserts false. We test deltas between consecutive depths, and further depths.
fn test_n_reverted_steps(
block_context: BlockContext,
#[values(default_l1_resource_bounds(), default_all_resource_bounds())]
resource_bounds: ValidResourceBounds,
#[values(CairoVersion::Cairo0, CairoVersion::Cairo1)] cairo_version: CairoVersion,
) {
let TestInitData { mut state, account_address, contract_address, mut nonce_manager } =
create_test_init_data(&block_context.chain_info, cairo_version);
let recursion_base_args = invoke_tx_args! {
resource_bounds,
sender_address: account_address,
};
// Invoke the `recursive_fail` function with 0 iterations. This call should fail.
let result = run_invoke_tx(
&mut state,
&block_context,
invoke_tx_args! {
nonce: nonce_manager.next(account_address),
calldata: recursive_function_calldata(&contract_address, 0, true),
..recursion_base_args.clone()
},
)
.unwrap();
// Ensure the transaction was reverted.
assert!(result.is_reverted());
let mut actual_resources_0 = result.receipt.resources.computation.clone();
let n_steps_0 = result.receipt.resources.computation.total_charged_steps();
let actual_fee_0 = result.receipt.fee.0;
// Invoke the `recursive_fail` function with 1 iterations. This call should fail.
let result = run_invoke_tx(
&mut state,
&block_context,
invoke_tx_args! {
nonce: nonce_manager.next(account_address),
calldata: recursive_function_calldata(&contract_address, 1, true),
..recursion_base_args.clone()
},
)
.unwrap();
// Ensure the transaction was reverted.
assert!(result.is_reverted());
let actual_resources_1 = result.receipt.resources.computation;
let n_steps_1 = actual_resources_1.total_charged_steps();
let actual_fee_1 = result.receipt.fee.0;
// Invoke the `recursive_fail` function with 2 iterations. This call should fail.
let result = run_invoke_tx(
&mut state,
&block_context,
invoke_tx_args! {
nonce: nonce_manager.next(account_address),
calldata: recursive_function_calldata(&contract_address, 2, true),