Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalidation of negative amounts and too many decimal points #135

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

dan-ziv
Copy link
Collaborator

@dan-ziv dan-ziv commented Apr 5, 2022

Description of the Changes

  • A fix for invalidation of negative amounts
  • A fix for invalidation of too many decimals points

Checklist

  • Changes have been done against master branch, and PR does not conflict
  • New unit / functional tests have been added (whenever applicable)
  • Test are passing in local environment
  • Docs have been updated
  • PR title is follow the Conventional Commits convention: <type>[optional scope]: <description>, e.g: fix: prevent racing of requests

This change is Reviewable

CarmitKl
CarmitKl previously approved these changes Apr 5, 2022
@dan-ziv dan-ziv requested a review from CarmitKl April 5, 2022 13:24
@dan-ziv dan-ziv merged commit d94b8ea into dev Apr 5, 2022
@dan-ziv dan-ziv deleted the fix/amount-validation branch April 5, 2022 19:00
dan-ziv pushed a commit that referenced this pull request Apr 5, 2022
 ## [1.1.0-dev.2](v1.1.0-dev.1...v1.1.0-dev.2) (2022-04-05)

### 🔧 Fixes

* invalidation of negative amounts and too many decimal points ([#135](#135)) ([d94b8ea](d94b8ea))
@dan-ziv
Copy link
Collaborator Author

dan-ziv commented Apr 5, 2022

🎉 This PR is included in version 1.1.0-dev.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dan-ziv pushed a commit that referenced this pull request Apr 6, 2022
 ## [1.1.0](v1.0.0...v1.1.0) (2022-04-06)

### 🧩 Features

* support more tokens on testnet ([#133](#133)) ([1e95d33](1e95d33))

### 🔧 Fixes

* invalidation of negative amounts and too many decimal points ([#135](#135)) ([d94b8ea](d94b8ea))
* new event driven implementation for deposit and withdraw ([#139](#139)) ([96d6b24](96d6b24))
* when clicking Max button on L2 network 0 is shown instead of max balance ([#134](#134)) ([fb4618b](fb4618b))
@dan-ziv
Copy link
Collaborator Author

dan-ziv commented Apr 6, 2022

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dan-ziv dan-ziv restored the fix/amount-validation branch September 6, 2022 11:18
@dan-ziv dan-ziv deleted the fix/amount-validation branch September 6, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants