Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git): upgrade gitoxide to v0.21 #4277

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Conversation

Byron
Copy link
Contributor

@Byron Byron commented Aug 17, 2022

This release comes with lenient configuration handling by default,
allowing to open repositories even their configuration values are
invalid (even for git), as long as there are viable defaults.

Furthermore this release adds the ability to open submodule repsitories.

Fixes #4266 and
fixes #4272
addresses performance in #4275

This release comes with lenient configuration handling by default,
allowing to open repositories even their configuration values are
invalid (even for git), as long as there are viable defaults.

Furthermore this release adds the ability to open submodule repsitories.

Fixes starship#4266 and
fixes starship#4272
@Byron
Copy link
Contributor Author

Byron commented Aug 17, 2022

I am not sure why CI is failing in git_status, I thought it was still using the git binary itself.

@davidkna davidkna changed the title upgrade gitoxide to v0.21 fix(git): upgrade gitoxide to v0.21 Aug 17, 2022
@davidkna
Copy link
Member

@Byron Some tests can fail intermittently (#886). In fact, the tests don't run on Windows CI at all without core.fsyncObjectFiles or sleep in-between git invocations.

Copy link
Member

@davidkna davidkna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've confirmed it fixes the issues in question.

Related to starship#4275 bringing
performance to spitting distance compared to git.
@Byron Byron force-pushed the gitoxide-upgrade branch from 3b441d3 to 0074669 Compare August 18, 2022 05:07
@andytom andytom merged commit f52ae55 into starship:master Aug 18, 2022
@andytom
Copy link
Member

andytom commented Aug 18, 2022

Thank you for the quick fix @Byron and thanks as always for reviewing @davidkna.

@Byron Byron deleted the gitoxide-upgrade branch August 18, 2022 07:25
Indyandie pushed a commit to Indyandie/starship that referenced this pull request Jul 26, 2023
* upgrade `gitoxide` to v0.21

This release comes with lenient configuration handling by default,
allowing to open repositories even their configuration values are
invalid (even for git), as long as there are viable defaults.

Furthermore this release adds the ability to open submodule repsitories.

Fixes starship#4266 and
fixes starship#4272

* Assure an object cache is set to speed up `commit.describe()`

Related to starship#4275 bringing
performance to spitting distance compared to git.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants