Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discoverability of data inputs #290

Closed
cliffckerr opened this issue Feb 22, 2024 · 2 comments
Closed

Discoverability of data inputs #290

cliffckerr opened this issue Feb 22, 2024 · 2 comments
Assignees

Comments

@cliffckerr
Copy link
Contributor

          Also maybe not specific to this PR but how does a user find out what format dataframes (like `fertility_rates` need to be in? Or rather, what they can/can't put in their CSVs. It's difficult to tell by looking through the code. I guess it's in `Pregnancy.metadata`? Maybe we should have a data container class that centralises these operations e.g., have the module contain a data object that has a specification of the columns/types etc. and also handles standardization/parsing - then the module's constructor could pass whatever representation of the data the user provided to a `load` method or similar on that class, and subsequently access the sanitised data via that class too (e.g.,`Pregnancy.fertility_rates.df`)

Originally posted by @RomeshA in #235 (comment)

@kaa2102
Copy link
Contributor

kaa2102 commented Feb 28, 2024

In the Save phase, can we consider saving common or targeted data in data frames (maybe using polar vs. pandas to for 20x speed and 25% less memory usage advantage) and printing with the results (or exporting to a JSON file)? The next logical question would be: 'what (a) basic, (b) advanced, and/or (c) custom data would users want to see?'

@cliffckerr cliffckerr added this to the Documentation milestone Mar 16, 2024
@kaa2102 kaa2102 self-assigned this Apr 8, 2024
@cliffckerr
Copy link
Contributor Author

Going to close for now, since much lower level than other docs issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants