Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The footer.html customization isn't being applied in the Sphinx PyData theme #381

Closed
JSchripsema-IDM opened this issue Mar 13, 2024 · 2 comments · Fixed by #382
Closed

The footer.html customization isn't being applied in the Sphinx PyData theme #381

JSchripsema-IDM opened this issue Mar 13, 2024 · 2 comments · Fixed by #382
Labels
documentation Improvements or additions to documentation helpwanted Please help!!

Comments

@JSchripsema-IDM
Copy link
Contributor

There's extra information about the license, privacy notice, and terms of use that isn't being applied to the compiled HTML in the PyData theme. It appears others have hit this issue and identified a fix here: pydata/pydata-sphinx-theme#1284
@JSchripsema-IDM JSchripsema-IDM added documentation Improvements or additions to documentation highpriority labels Mar 13, 2024
@cliffckerr cliffckerr mentioned this issue Mar 13, 2024
Merged
@cliffckerr
Copy link
Contributor

cliffckerr commented Mar 14, 2024 •
edited
Loading

Good news and bad news -- I fixed it, but it looks awful! Much as I love div-wrangling, I could use help from an HTML person here! See branch fix-footer
image

@cliffckerr cliffckerr added the helpwanted Please help!! label Mar 14, 2024
@cliffckerr
Copy link
Contributor

Fixed -- not beautiful, but not embarrassing :)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation helpwanted Please help!!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix footer starsimhub/starsim
2 participants
@cliffckerr @JSchripsema-IDM