Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SIR plotting #440

Closed
cliffckerr opened this issue Apr 2, 2024 · 2 comments
Closed

Fix SIR plotting #440

cliffckerr opened this issue Apr 2, 2024 · 2 comments
Assignees
@cliffckerr @kaa2102
Labels
bug Something isn't working highpriority High priority for collaborators
Milestone
Critical-to-quali...

Comments

@cliffckerr
Copy link
Contributor

Uses timestep rather than sim step -- would be fixed if modules had access to the Sim object.
@cliffckerr cliffckerr added bug Something isn't working priority labels Apr 2, 2024
@cliffckerr cliffckerr added this to the Usability milestone Apr 2, 2024
@kaa2102 kaa2102 self-assigned this Apr 3, 2024
@cliffckerr cliffckerr added the highpriority High priority for collaborators label Apr 8, 2024
@daniel-klein
Copy link
Contributor

As far as I know, SIR is unique in having a plot() method as part of the disease module. Seems like a reasonable pattern, but does not extend well to multi-disease simulations etc. In addition tomodule.plot(), we previously discussed a pattern like sim.plot(modules=sir).

@cliffckerr cliffckerr self-assigned this Apr 10, 2024
@cliffckerr cliffckerr added the MVP label Apr 30, 2024
@cliffckerr cliffckerr mentioned this issue May 7, 2024
Merged
4 tasks
@cliffckerr
Copy link
Contributor Author

Closed by #488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cliffckerr cliffckerr

@kaa2102 kaa2102

Labels
bug Something isn't working highpriority High priority for collaborators
Projects
None yet
Milestone
Critical-to-quality feature catalog c...
Development

No branches or pull requests
4 participants
@cliffckerr @daniel-klein @kaa2102 @VFrances-IDM