Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add validation for name field against aliases #726

Open
DogmaDragon opened this issue Oct 27, 2023 · 3 comments
Open

[Feature] Add validation for name field against aliases #726

DogmaDragon opened this issue Oct 27, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@DogmaDragon
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Right now, stash-box allows adding an identical alias as the name. Since search and scraping already matches both, I feel like this is redundant clutter.

Describe the solution you'd like
Add validation for name field against aliases in the frontend.

Additional context
image

@DogmaDragon DogmaDragon added the enhancement New feature or request label Oct 27, 2023
@AdultSun
Copy link
Contributor

Also worth noting that Stash already prevents identical aliases. I've seen others mention this causing errors when trying to scrape from a Stash-Box into Stash, but I haven't run into it personally yet.

@DogmaDragon
Copy link
Contributor Author

True, but only if they have the same capitalization. That's a different issue, stashapp/stash#4250.

@echo6ix
Copy link

echo6ix commented Oct 27, 2023

I had a different take on resolving this issue earlier this year #610

TLDR:

  • Consolidate the name and alias fields into one Names field
  • Present the names using filter chips styling
    • Filter chips look exactly the same as the incumbent chips, but they add a trailing drop down caret icon
    • This gives each chip the option to Set as primary name and Delete name
    • A name set as primary gets a unique chip presentation to stand out
      • Either a different colored chip
      • Or a chip with a leading icon, such as a star

image

This solves several issues with manual data entry such as the need for validation against duplicate aliases, and forgetting to re-add a primary name as an alias if the submitter is flipping primary names.

Alternate implementation

Thought of alternate implementation of the above without using a filter chip

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants