Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Renamed files/directories keep getting detected as duplicates repeatedly #1426

Closed
deliciousnights opened this issue May 24, 2021 · 3 comments · Fixed by #1427
Closed
Labels
bug Something isn't working
Milestone

Comments

@deliciousnights
Copy link

When renaming some of the already scanned files and re-scanning leads to the following log entries:

[2021-05-24 23:41:40] Y:\ph\thestartofus\thestartofus (20201202) [ph5fc7a8306a205].mp4 not found. Calculating oshash...
[2021-05-24 23:41:40] Y:\ph\thestartofus\thestartofus (20201202) [ph5fc7a8306a205].mp4 already exists. Duplicate of Y:\ph\thestartofus\THESTARTOFUS (20201202) [ph5fc7a8306a205].mp4

Looks like it happens only if the only change in the file name is a changed of a letter(s) case (upper/lower).
These messages do not go away with repeated scans.

To Reproduce
Steps to reproduce the behavior:

  1. Have Stash scan a certain file
  2. Rename the file, but only change a letter from uppercase to lowercase, or vice-versa
  3. Scan the file again

Expected behavior
Stash should accept the new name and forget the old, non-existing one.

Stash Version: (from Settings -> About):
v0.7.0

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Firefox
  • Version 88.0.1
@deliciousnights deliciousnights added the help wanted Extra attention is needed label May 24, 2021
@bnkai
Copy link
Collaborator

bnkai commented May 24, 2021

Stash relies on os.Stat for the duplicate checks. If os.Stat returns ok then that probably means that the filesystem is case insensitive? Can you check what filesystem is used in the Y: drive ?

@WithoutPants
Copy link
Collaborator

Confirmed on Windows local drive.

@WithoutPants WithoutPants added bug Something isn't working and removed help wanted Extra attention is needed labels May 25, 2021
@WithoutPants WithoutPants added this to the Version 0.8.0 milestone May 25, 2021
@deliciousnights
Copy link
Author

Filesystem is NTFS on windows - case insensitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants