Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Generic key / value store for plugin config #2207

Closed
Tweeticoats opened this issue Jan 5, 2022 · 1 comment · Fixed by #4143
Closed

[Feature] Generic key / value store for plugin config #2207

Tweeticoats opened this issue Jan 5, 2022 · 1 comment · Fixed by #4143
Labels
feature Pull requests that add a new feature

Comments

@Tweeticoats
Copy link
Contributor

Is your feature request related to a problem? Please describe.
For plugin config it would be useful to have a generic key / value store configuration needed for plugins.
If there was a graphql api for get_config(key) and update_config(key,value)

Ideally you could store a json object as the value allowing you to store as many options as needed for the scraper or plugin.

Describe the solution you'd like
A table in the database to store this config:
config (key varchar(255) primary key, value text)

A put config method in graphql:
mutation update_config(key,value)

A get config method:
query get_config(key)

Describe alternatives you've considered
Storing this config in a studio.
You can easily create a new studio if it does not exist and store all the config in the description field as that is a text field.

@Maista6969
Copy link
Contributor

Solved by #4143

@WithoutPants WithoutPants linked a pull request Jan 17, 2024 that will close this issue
@WithoutPants WithoutPants added this to the Version 0.24.0 milestone Jan 17, 2024
@WithoutPants WithoutPants added the feature Pull requests that add a new feature label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants