Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Bulk editing performer's country (i.e. changing California to United States of America) ends up in a weird state #3642

Closed
Kaelfurian opened this issue Apr 5, 2023 · 2 comments · Fixed by #4565
Labels
bug Something isn't working

Comments

@Kaelfurian
Copy link

Describe the bug
Bulk editing of a group of performers from the performer page does not correctly use the drop down of available known countries and when inputting in United States of America (for example), it ends up saving this value [United States of America] (and not 🇺🇸 United States of America) so it is not possible to filter for it making them difficult to locate again.

In short, the bulk editor does not correctly set the country.

To Reproduce
Steps to reproduce the behavior:

  1. Search for a group of performers that have an incorrect country set (i.e. California)
  2. Click on 'Select All'
  3. Press the Edit button
  4. Change country to United States of America
  5. Press save.
  6. Locate one of the edited performers and note that it is not set to 🇺🇸 United States of America but United States of America.

Expected behavior
Either 🇺🇸 United States of America should be selectable or inputting in United States of America should map to 🇺🇸 United States of America.

Screenshots
image
This will be set but the flag will not appear next to the performer name nor will it appear under any searches for 🇺🇸 United States of America.

Workaround
You can reset it back to the correct 🇺🇸 United States of America instead of just United States of America by changing the value on the performer's page. (not possible with the bulk editor)

Stash Version: (from Settings -> About):
v0.20.1

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Firefox
  • Version 111.0.1
@Kaelfurian Kaelfurian added the bug report Bug reports that are not yet verified label Apr 5, 2023
@MrX292
Copy link
Contributor

MrX292 commented Apr 5, 2023

they are saved as iso ALPHA-2 codes in the database, so right now you would need to use us for United States of America for it to work correctly.

@Kaelfurian
Copy link
Author

Kaelfurian commented Apr 5, 2023

Thank you! That workaround is perfect, using us in the bulk editor works!

Edit: I also found my mistagged ones (in case someone else finds this thread having done the same thing I had) by manipulating the query parameters in the URL to set to "United States of America" when trying to make a filter, which allowed me to find my mistagged ones and change them to us.

@WithoutPants WithoutPants added this to the Backlog milestone Jun 7, 2023
@WithoutPants WithoutPants added bug Something isn't working and removed bug report Bug reports that are not yet verified labels Jun 7, 2023
@github-project-automation github-project-automation bot moved this to To triage in Bug fixing Feb 13, 2024
@WithoutPants WithoutPants moved this from To triage to Ready in Bug fixing Feb 13, 2024
@WithoutPants WithoutPants moved this from Ready to In review in Bug fixing Feb 15, 2024
@WithoutPants WithoutPants modified the milestones: Backlog, Version 0.25.0 Feb 15, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Bug fixing Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants