Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Scene Duplicate Checker - select smaller files to delete - larger file is selected to delete if smaller files been previously merged in a scene #4689

Closed
laurus-lx opened this issue Mar 14, 2024 · 0 comments · Fixed by #4800
Labels
bug report Bug reports that are not yet verified

Comments

@laurus-lx
Copy link

Describe the bug
In Scene Duplicate Checker - when selecting files to delete - keep larger file/select to delete smaller file:
It will pick smaller file to keep, larger file to delete in cases when 2 smaller files been previously merged
E.g.

File 1
1:31:15 922.92MB 720x480 1.41 mbps mpeg4

File 2
1:31:15 683.8MB 512x344 1.05 mbps mpeg4

File 3
1:31:15 683.8MB 512x344 1.05 mbps mpeg4

Files 2 & 3 are identical ~ 680MB . They were previously merged (in to a single scene).
File 1 is larger ~920MB

Duplicate checker in this case will select files to delete/keep as follows:

  • File 1 - delete
  • File 2 & 3 - keep

To Reproduce

Replicate file setup as described above, run duplicate checker

Expected behavior

Smaller files should have been deleted (even if they sum is larger)

Stash Version: (from Settings -> About):

v0.25.1

@laurus-lx laurus-lx added the bug report Bug reports that are not yet verified label Mar 14, 2024
@github-project-automation github-project-automation bot moved this to To triage in Bug fixing Mar 14, 2024
@laurus-lx laurus-lx changed the title [Bug Report] Scene Duplicate Checker - select file to delete by size - larger file gets deleted when smaller files been previously merged to a scene [Bug Report] Scene Duplicate Checker - select smaller files to delete - larger file gets deleted if smaller files been previously merged in a scene Mar 14, 2024
@WithoutPants WithoutPants changed the title [Bug Report] Scene Duplicate Checker - select smaller files to delete - larger file gets deleted if smaller files been previously merged in a scene [Bug Report] Scene Duplicate Checker - select smaller files to delete - larger file is selected to delete if smaller files been previously merged in a scene Mar 14, 2024
@github-project-automation github-project-automation bot moved this from To triage to Done in Bug fixing May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Bug reports that are not yet verified
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant