Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Play Count button should be hidden if 'Enable Scene Play history' is disabled #4979

Closed
IAmKontrast opened this issue Jun 17, 2024 · 4 comments

Comments

@IAmKontrast
Copy link

I have disabled the feature 'Enable Scene Play history'. Therefore the new Play Count button from #4714 should not be visible.
Tried to hide it with css but unfortunately this also hide the O Count. Any idea?

@IAmKontrast IAmKontrast changed the title [Feature] Hide Play Count button if 'Enable Scene Play history' is disabled [Feature] Play Count button should be hidden if 'Enable Scene Play history' is disabled Jun 17, 2024
@sleetx
Copy link

sleetx commented Jun 17, 2024

Looks like both counters use the same class names, so it needs some trickier CSS. Try this:

span.scene-toolbar-group > span:nth-child(2) > div.count-button {
    display: none;
}  

@WithoutPants
Copy link
Collaborator

Enable play history needs better wording. Enabling it means that the play count will be incremented when a scene is played (in accordance with the minimum play percent setting). The Play Count button allows for manually incrementing the play count for users that don't want it to be done automatically.

@IAmKontrast
Copy link
Author

Looks like both counters use the same class names, so it needs some trickier CSS. Try this:

span.scene-toolbar-group > span:nth-child(2) > div.count-button {
    display: none;
}  

Works like a charm! Thank you!

@IAmKontrast
Copy link
Author

Enable play history needs better wording. Enabling it means that the play count will be incremented when a scene is played (in accordance with the minimum play percent setting). The Play Count button allows for manually incrementing the play count for users that don't want it to be done automatically.

Renaming (adding words like automatic or auto-increment) would make it definitely more obvious. Also merging Enable Scene Play history and Minimum Play Percent to a single settings row would help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants