Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Wrap all text in react-intl for localization #566

Closed
ghost opened this issue May 21, 2020 · 0 comments · Fixed by #1471
Closed

[Feature] Wrap all text in react-intl for localization #566

ghost opened this issue May 21, 2020 · 0 comments · Fixed by #1471
Labels
feature Pull requests that add a new feature
Milestone

Comments

@ghost
Copy link

ghost commented May 21, 2020

To be able to translate the application, all text has to be wrapped in <FormattedMessage> or formatMessage. We may have to rethink the way we define messages to avoid problems with extraction. I suspect explicitly calling defineMessage for all text centrally in each component is cleaner than defining the text on use, particularly since we can't always use <FormattedMessage>.

@bnkai bnkai added this to the Version 0.3.0 milestone May 21, 2020
@bnkai bnkai added the feature Pull requests that add a new feature label May 21, 2020
@ghost ghost modified the milestones: Version 0.3.0, Backlog Aug 25, 2020
@WithoutPants WithoutPants modified the milestones: Backlog, Version 0.8.0 Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants