Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bioconductor / CRAN release ? #6

Open
bvieth opened this issue Oct 29, 2019 · 3 comments
Open

Bioconductor / CRAN release ? #6

bvieth opened this issue Oct 29, 2019 · 3 comments

Comments

@bvieth
Copy link

bvieth commented Oct 29, 2019

Dear Koen,

do you have any plans to release zingeR on Bioconductor or CRAN in the near future ?

Kind regards
Beate

@koenvandenberge
Copy link
Member

Hi Beate,

Congrats on your recent paper on comparing single-cell pipelines; very interesting work.
I am not planning to submit zingeR to Bioconductor nor CRAN. Would that be useful to you?

Best,
Koen

@bvieth
Copy link
Author

bvieth commented Oct 30, 2019

Hey Koen,
Thank you very much :)
Actually, yes that would be useful. Bioconductor only allows for dependencies hosted on Bioconductor or CRAN, not github, and I would like to move powsimR form github to Bioconductor.
An option for me would be to incorporate your source code into my package directly, if that is ok for you ? Of course I would cite it accordingly.

Best, Beate

@koenvandenberge
Copy link
Member

koenvandenberge commented Nov 15, 2019

Hi Beate,
My apologies for being late at getting back at this.
For now I would suggest to incorporate the function in your package, but to print a message to clearly state whenever it's used. Here is an example of what Mike Love is doing in DESeq2 when ashr is being used: https://github.com/mikelove/DESeq2/blob/master/R/lfcShrink.R#L441-L443

Note that you should only need to incorporate the zeroWeightsLS function; the other functions are already incorporated into zinbwave (which is a Bioconductor package).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants