Replace commas with dots ...

A port of a fix that was added in v2. Ref statamic/v2-hub#2428
statamic · Nov 20, 2020 · 927890a · 927890a
1 parent dea77e8
commit 927890a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/Forms/Submission.php b/src/Forms/Submission.php
@@ -45,7 +45,7 @@ public function id($id = null)
     {
         return $this->fluentlyGetOrSet('id')
             ->getter(function ($id) {
-                return $this->id = $id ?: microtime(true);
+                return $this->id = $id ?: str_replace(',', '.', microtime(true));
             })
             ->args(func_get_args());
     }

diff --git a/tests/Forms/SubmissionTest.php b/tests/Forms/SubmissionTest.php
@@ -20,4 +20,16 @@ public function the_id_is_generated_the_first_time_but_can_be_overridden()
 
         $this->assertEquals('123', $submission->id());
     }
+
+    /** @test */
+    public function generated_ids_dont_have_commas()
+    {
+        // this test becomes unnecessary if we ever move away from using microtime for ids.
+
+        setlocale(LC_ALL, 'de_DE');
+
+        $submission = Form::make('test')->makeSubmission();
+
+        $this->assertStringNotContainsString(',', $submission->id());
+    }
 }