-
-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] Add entry password protection #10800
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
references because there's potential for overlapping ids across types - entries, terms, etc. prefix the session key to keep references and schemes separate
- hasEnteredValidPassword avoids checking both session keys if it doesnt need to - get rid of the guard class. it doesnt really do much. - move the guards into the protector class
duncanmcclean
added a commit
to statamic/statamic
that referenced
this pull request
Oct 7, 2024
duncanmcclean
added a commit
to statamic/statamic
that referenced
this pull request
Oct 7, 2024
* Nocache database driver Related: statamic/cms#10671 * Prevent query parameters bloating the static cache Related: statamic/cms#10701 * Add entry password protection Related: statamic/cms#10800 * Fix small typo Related: statamic/cms#10824 * Move nocache js back to end of body but make configurable Related: statamic/cms#10898
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the existing password protection scheme with the concept of local passwords. This allows users to protect individual entries based on a password field.
To use a local entry password, you start by defining the field containing the password. In this example, we'll call the field
password
:Next, you'll need to apply the protection scheme on the entry, along with the password.
Now, users can access the protected page using
local-password
.If the protection scheme has both
allowed
andfield
configured, the passwords inallowed
will act as master passwords. In our example, you'll be able to access the protected entry either withmaster-password
orlocal-password
.If you use the
local-password
, the session will be scoped to the entry's ID. This ensures that you can only access the entry you entered the password for. This also ensures that multiple entries can share the same local password but still control access individually.If you use the
master-password
, the session will be scoped to the protection scheme and immediately grant access to all other entries as well.And if, for whatever reason, an entry uses a local password that is the same as a master password, access will be scoped to the entry as well. This ensures that global access won't be granted accidentally.
A little hack you can use to enable password protection only if an entry's password field is filled: