Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trans] id_ID #2426

Merged
merged 6 commits into from
Nov 6, 2020
Merged

[trans] id_ID #2426

merged 6 commits into from
Nov 6, 2020

Conversation

suabahasa
Copy link
Contributor

No description provided.

@jasonvarga jasonvarga marked this pull request as draft September 15, 2020 02:02
@jasonvarga
Copy link
Member

Thank you for this PR. Are you planning on adding the rest of the translations?

@ebeauchamps
Copy link
Contributor

Indonesian..interesting. Did you try following those guidelines to help you out? language code should be "id"...but you already knows that!

@suabahasa
Copy link
Contributor Author

Yes, I will commit the rest translation progressively.

@jasonvarga
Copy link
Member

Great! Just mark the PR as ready for review when you're done.

@suabahasa suabahasa changed the title [trans] id_ID: 60% translation of validation.php [trans] id_ID Sep 16, 2020
@suabahasa
Copy link
Contributor Author

I have a little knowledge about using git, is it common that this pull request include commit from 182164f and b919007 ?

@suabahasa suabahasa marked this pull request as ready for review September 16, 2020 05:36
ebeauchamps
ebeauchamps reviewed Sep 16, 2020
View reviewed changes
Copy link
Contributor

@ebeauchamps ebeauchamps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! you also have to generate an id.json file. You can also duplicate any other xx.json file found in vendor/statamic/cms/resources/lang, change the duplicate name to id.json and translate all English keys in Indonesian

@suabahasa
Copy link
Contributor Author

Hello! you also have to generate an id.json file. You can also duplicate any other xx.json file found in vendor/statamic/cms/resources/lang, change the duplicate name to id.json and translate all English keys in Indonesian.

Hi. Thanks for guide.

jasonvarga
jasonvarga requested changes Sep 16, 2020
View reviewed changes
resources/lang/id.json Outdated
Comment on lines 208 to 795
"This is the root page": "",
"This site is running the newest version of Statamic.": "",
"This user already exists.": "",
"Time Enabled": "",
"Time Required": "",
"Title": "",
"Today": "",
"Toggle Button": "",
"Toggle Dark Mode": "",
"Toggle Fullscreen Mode": "",
"Toggle Header Cell": "",
"Toggle Mobile Nav": "",
"Toggle Nav": "",
"Toggle Sidebar": "",
"Toolbar Mode": "",
"Tools": "",
"Tree": "",
"Trial Mode": "",
"Try again": "",
"Type": "",
"Typeahead Field": "",
"Unable to change password": "",
"Unable to delete filter preset": "",
"Unable to save changes": "",
"Unable to save column preferences.": "",
"Unable to save favorite": "",
"Unable to save filter preset": "",
"Unable to save role": "",
"Unable to save user group": "",
"Unable to update filter preset": "",
"Unauthorized": "",
"Uncheck All": "",
"Underline": "",
"Uninstall": "",
"Uninstalling :package": "",
"Unlink": "",
"Unlisted Addons": "",
"Unordered List": "",
"Unpin from Favorites": "",
"Unpublish": "",
"Unpublish Entry|Unpublish :count Entries": "",
"Unpublished": "",
"Unsaved changes": "",
"Up to date": "",
"Update": "",
"Update Search Indexes": "",
"Update to :version": "",
"Update to Latest": "",
"Updater": "",
"Updates": "",
"Upload": "",
"Upload file": "",
"URL": "",
"Useful Links": "",
"User": "",
"User created": "",
"User deleted": "",
"User group created": "",
"User group deleted": "",
"User group saved": "",
"User group updated": "",
"User Groups": "",
"User Information": "",
"User saved": "",
"Username": "",
"Users": "",
"Utilities": "",
"Validation": "",
"Value": "",
"View": "",
"View additional releases": "",
"View All": "",
"View History": "",
"View Site": "",
"View Useful Links": "",
"Visit URL": "",
"Whoops!": "",
"Widgets": "",
"Width": "",
"Words": "",
"Working Copy": "",
"Working copy has unsaved changes": "",
"Write": "",
"You are not authorized to configure navs.": "",
"You are not authorized to create collections.": "",
"You are not authorized to create forms.": "",
"You are not authorized to create navs.": "",
"You are not authorized to create taxonomies.": "",
"You are not authorized to delete navs.": "",
"You are not authorized to delete this collection.": "",
"You are not authorized to delete this taxonomy.": "",
"You are not authorized to edit this collection.": "",
"You are not authorized to edit this taxonomy.": "",
"You are not authorized to run this action.": "",
"You are not authorized to scaffold resources.": "",
"You are not authorized to view collections.": "",
"You are not authorized to view navs.": "",
"You are not authorized to view this collection.": "",
"Your Favorites": "",
"Your working copy will be replaced by the contents of this revision.": ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are still empty.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, will commit the rest soon

@jasonvarga jasonvarga marked this pull request as draft September 16, 2020 13:58
@duncanmcclean
Copy link
Member

@suabahasa It looks like the values are no longer blank. Is this pull request ready for review?

@suabahasa
Copy link
Contributor Author

@damcclean there are left about 20% of string (id.json) not yet translated. A bit busy this week, will commit the 20% the rest and submit it for review

@duncanmcclean
Copy link
Member

@damcclean there are left about 20% of string (id.json) not yet translated. A bit busy this week, will commit the 20% the rest and submit it for review

No rush, just wanted to know how it's going 😄

@jasonvarga
Copy link
Member

If you don't mind, I'm going to use Google Translate to fill in the missing lines shortly just so I can get this merged. You can feel free to review it after I do that. Thank you for the progress!

@suabahasa
Copy link
Contributor Author

Sure, I will happy to review the translation. Thanks

@jasonvarga jasonvarga marked this pull request as ready for review November 6, 2020 02:18
@jasonvarga jasonvarga merged commit 77422d6 into statamic:master Nov 6, 2020
@jasonvarga
Copy link
Member

Thank you again. I've filled in the translations in dfbc54c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebeauchamps ebeauchamps ebeauchamps left review comments

@jasonvarga jasonvarga jasonvarga requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suabahasa @jasonvarga @ebeauchamps @duncanmcclean