🐛 add status to LocalizedTerm #2950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like such a failure now 😔 |
|
@jasonvarga not sure what to do with the failing tests (cant really see why they failed) but I'm guessing it could be the inline comments. Should I remove those and re-push? |
|
I can't see why they failed either, they just... did. I manually re-ran them, so if you're getting lots of notifications, that was because of me. If you want, remove that comment as it's not super necessary, and maybe a new commit will kick out whatever glitch is happening. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a status of
publishedfor all terms which fixes #2949Currently there is no concept of status for Taxonomy Terms which makes sense. Maybe this should be expanded upon later to check if any terms exist? But for now, since all terms are considered published in other senses, it feels like a sensible default to start with.