Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update method signatures #3012

Merged
merged 3 commits into from
Dec 16, 2020
Merged

update method signatures #3012

merged 3 commits into from
Dec 16, 2020

Conversation

edalzell
Copy link
Contributor

The method were missing the return type hint so intellisense was complaining.

jasonvarga
jasonvarga requested changes Dec 14, 2020
View reviewed changes
Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be @method static returnvalue method(args)

@edalzell
Copy link
Contributor Author

Made those changes @jasonvarga

jasonvarga
jasonvarga requested changes Dec 15, 2020
View reviewed changes
src/Facades/Term.php Outdated Show resolved Hide resolved
@jasonvarga jasonvarga changed the base branch from master to 3.0 December 16, 2020 15:28
@jasonvarga jasonvarga merged commit ef1ec33 into statamic:3.0 Dec 16, 2020
@edalzell edalzell deleted the term-facade branch December 16, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonvarga jasonvarga jasonvarga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edalzell @jasonvarga