Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filters to the addon AddonServiceProvider.php #3093

Conversation

jonassiewertsen
Copy link
Contributor

I did notice that we explicitly do allow to register tags, fieldtypes, modifiers, widgets and others, but no filters.

This PR does add the possibility to register filters like other components: https://statamic.dev/extending/addons#registering-components

protected $filters = [
    \Acme\Example\Filters\First::class,
    \Acme\Example\Filters\Second::class,
    // etc...
];

I am happy to update the docs as well, if this is getting merged.

Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but can we call these scopes instead?

@jonassiewertsen
Copy link
Contributor Author

jonassiewertsen commented Jan 11, 2021

Should we add actions as well?

@jasonvarga
Copy link
Member

Sure

@jasonvarga jasonvarga merged commit efa5b10 into statamic:3.0 Jan 11, 2021
@jasonvarga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants