Improve cached asset handling #3201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
amazing 🙌🏼 was just working through this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2828 we added caching to asset listings.
Inside the asset query builder it converts paths to asset objects. As part of that, if the asset file doesn't exist, it'll return null.
We discovered an issue where if you delete an asset by hand during the cache window (through the filesystem or by git), you'd get an error because the asset path (which was still in the cache) was converted to null (because the actual file doesn't exist).
We fixed this by filtering out null values when you don't care how many are supposed to be returned.
But when you do care (like when using
paginate, ortake), we'll check if there are any nulls, if there are we bust the cache and requery.