Skip to content

[4.x] Fix new child entries not propagating to appropriate position in other sites trees #7302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 10, 2023
Merged

[4.x] Fix new child entries not propagating to appropriate position in other sites trees #7302

merged 7 commits into from
Nov 10, 2023

Conversation

arthurperton
Copy link
Contributor

Fixes #7127.

@what-the-diff
Copy link

what-the-diff bot commented Jan 5, 2023 •
edited
Loading

  • Added a new method to the Entry class called addToStructure()
  • Removed code from LocalizeEntryController that was moved into the makeLocalization() method in step 1 above
  • Updated tests for changes made in steps 1 and 2 above

@arthurperton
Copy link
Contributor Author

arthurperton commented Jan 5, 2023 •
edited
Loading

I guess a newly created localization should always be added to the structure.

@jasonvarga jasonvarga changed the base branch from 3.3 to 4.x November 10, 2023 20:38
@jasonvarga jasonvarga changed the title Propagate entry parent [4.x] Propagate entry parent Nov 10, 2023
@jasonvarga jasonvarga changed the title [4.x] Propagate entry parent [4.x] Fix new child entries not propagating to appropriate position in other sites trees Nov 10, 2023
@jasonvarga jasonvarga merged commit 30db081 into statamic:4.x Nov 10, 2023
@arthurperton arthurperton deleted the issue/7127-propagate-entry-parent branch December 19, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonvarga jasonvarga jasonvarga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-Site: New Child Entry propagates localized entry to wrong parent
2 participants
@arthurperton @jasonvarga