Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text align in Bard #470

Closed
Joe2824 opened this issue Feb 16, 2021 · 7 comments
Closed

Text align in Bard #470

Joe2824 opened this issue Feb 16, 2021 · 7 comments

Comments

@Joe2824
Copy link

Joe2824 commented Feb 16, 2021

It would be beautiful to align text inside bard without any plugin.

@jasonvarga
Copy link
Member

If you've used a plugin for this, please link it.

@jeremyvienney
Copy link

TipTap 2 will have it built in and will be very soon be released, see here : ueberdosis/tiptap#547 (comment)
@jasonvarga Is Statamic a sponsor of tiptap and have an access to the closed beta ?
Here is the "alpha" align plugin : https://www.npmjs.com/package/@tiptap/extension-text-align

@duncanmcclean
Copy link
Member

duncanmcclean commented Mar 2, 2021

Even when TipTap 2 is released, I imagine it will be a while before Statamic updates Bard to support it, as it would mean introducing a breaking change and possibly changing the way some things work (I've not looked into TipTap 2 that much yet).

@jeremyvienney
Copy link

Indeed Duncan, but it can probably be easier than a big refactor - as they said at least :) https://github.com/ueberdosis/tiptap#faq-should-i-start-to-integrate-tiptap-1-or-wait-for-tiptap-2
Nevertheless you're right it will break for people who created custom plugins for Bard exclusively.

In the meantime, here is a working solution for V1 : ueberdosis/tiptap#544 (comment)

@jacksleight
Copy link

jacksleight commented Jun 1, 2022

With the upcoming upgrade to TipTap2 this should be fairly simple to implement with the official text align extension (https://tiptap.dev/api/extensions/text-align). Be great to have 1st party text align support in Bard.

@jonassiewertsen
Copy link

This is the PR if anybody wants to follow the status
statamic/cms#6043

@jacksleight
Copy link

This one can be closed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants