Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate variant_id flavors #9

Open
grosscol opened this issue Aug 5, 2021 · 0 comments
Open

Differentiate variant_id flavors #9

grosscol opened this issue Aug 5, 2021 · 0 comments
Labels
triage Landing area for issues discovered during development.

Comments

@grosscol
Copy link
Collaborator

grosscol commented Aug 5, 2021

Issue or current state

variant_id is a variable name that has different meanings depending on the context.
These are easily confused and not entirely obvious which meaning is expected even when they appear in context.

  • In sequences it's expected to be the VCF format of chrom-pos-ref-alt
  • In the browser routes, e.g. /variant/api/snv/<string:variant_id> it is expected to be a dbSNP rsID

Resolved when

Different expectations of content have different variable names.

  • var_ref_id for the variant reference identifiers.
  • var_vcf_id for the VCF style variant identifiers.
@grosscol grosscol added the triage Landing area for issues discovered during development. label Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Landing area for issues discovered during development.
Projects
None yet
Development

No branches or pull requests

1 participant