Merge pull request #103 from staticdev/enhancement-git-commands

Enhancement Git Commands

Author: Thiago C. D'Ávila

mypy.ini

@@ -19,6 +19,9 @@ warn_unreachable = True
 warn_unused_configs = True
 warn_unused_ignores = True
 
+[mypy-_pytest.*]
+ignore_missing_imports = True
+
 [mypy-inquirer]
 ignore_missing_imports = True
 

src/git_portfolio/__main__.py

@@ -64,6 +64,16 @@ def checkout(args: Tuple[str]) -> Union[res.ResponseFailure, res.ResponseSuccess
     )
 
 
+@main.command("commit", context_settings={"ignore_unknown_options": True})
+@click.argument("args", nargs=-1)
+@git_command
+def commit(args: Tuple[str]) -> Union[res.ResponseFailure, res.ResponseSuccess]:
+    """CLI `git commit` command."""
+    return guc.GitUseCase().execute(
+        CONFIG_MANAGER.config.github_selected_repos, "commit", args
+    )
+
+
 @main.command("pull")
 @click.argument("args", nargs=-1)
 @git_command
@@ -74,7 +84,7 @@ def pull(args: Tuple[str]) -> Union[res.ResponseFailure, res.ResponseSuccess]:
     )
 
 
-@main.command("push")
+@main.command("push", context_settings={"ignore_unknown_options": True})
 @click.argument("args", nargs=-1)
 @git_command
 def push(args: Tuple[str]) -> Union[res.ResponseFailure, res.ResponseSuccess]:

tests/test_config_manager.py

@@ -1,77 +1,91 @@
 """Test cases for the config manager module."""
-from unittest.mock import Mock
-from unittest.mock import patch
-
 import pytest
+from _pytest.tmpdir import Path
+from pytest_mock import MockerFixture
 
 from git_portfolio import config_manager as cm
 
 
-@patch("os.path.join")
-class TestConfigManager:
-    """ConfigManager test class."""
+@pytest.fixture
+def mock_os_join_path(mocker: MockerFixture) -> MockerFixture:
+    """Fixture for mocking os.path.join."""
+    return mocker.patch("os.path.join")
+
+
+@pytest.fixture
+def mock_yaml_dump(mocker: MockerFixture) -> MockerFixture:
+    """Fixture for mocking yaml.dump."""
+    return mocker.patch("yaml.dump")
 
-    def test_init_invalid_config(self, os_join_path: Mock, tmp_path: Mock) -> None:
-        """It trucantes the file."""
-        filename = "config1.yaml"
-        d = tmp_path
-        p = d / filename
-        p.write_text("in:valid")
-        os_join_path.side_effect = [str(d), str(p)]
-        cm.ConfigManager()
-        # os_truncate.assert_called_once_with(0)
 
-    def test_save_invalid_yaml(self, os_join_path: Mock, tmp_path: Mock) -> None:
-        """It trucantes the file."""
-        filename = "config.yaml"
-        content = (
-            "github_access_token: aaaaabbbbbccccc12345"
-            "github_hostname: ''"
-            "github_selected_repos:"
-            " - staticdev/test"
-        )
-        d = tmp_path
-        p = d / filename
-        p.write_text(content)
-        os_join_path.side_effect = [str(d), str(p)]
-        cm.ConfigManager()
-        # os_truncate.assert_called_once_with(0)
+def test_init_invalid_config(tmp_path: Path, mock_os_join_path: MockerFixture) -> None:
+    """It trucantes the file."""
+    filename = "config1.yaml"
+    d = tmp_path
+    p = d / filename
+    p.write_text("in:valid")
+    mock_os_join_path.side_effect = [str(d), str(p)]
+    cm.ConfigManager()
+    # os_truncate.assert_called_once_with(0)
 
-    def test_save_config_no_file(self, os_join_path: Mock, tmp_path: Mock) -> None:
-        """It raises AttributeError."""
-        d = tmp_path
-        os_join_path.side_effect = [str(d), str(d / "config.yaml")]
-        manager = cm.ConfigManager()
-        with pytest.raises(AttributeError):
-            manager.save_config()
 
-    def test_save_config_empty_file(self, os_join_path: Mock, tmp_path: Mock) -> None:
-        """It raises AttributeError."""
-        filename = "config2.yaml"
-        d = tmp_path
-        p = d / filename
-        p.write_text("")
-        os_join_path.side_effect = [str(d), str(p)]
-        manager = cm.ConfigManager(filename)
-        with pytest.raises(AttributeError):
-            manager.save_config()
+def test_save_invalid_yaml(tmp_path: Path, mock_os_join_path: MockerFixture) -> None:
+    """It trucantes the file."""
+    filename = "config.yaml"
+    content = (
+        "github_access_token: aaaaabbbbbccccc12345"
+        "github_hostname: ''"
+        "github_selected_repos:"
+        " - staticdev/test"
+    )
+    d = tmp_path
+    p = d / filename
+    p.write_text(content)
+    mock_os_join_path.side_effect = [str(d), str(p)]
+    cm.ConfigManager()
+    # os_truncate.assert_called_once_with(0)
 
-    @patch("yaml.dump")
-    def test_save_config_success(
-        self, yaml_dump: Mock, os_join_path: Mock, tmp_path: Mock
-    ) -> None:
-        """It dumps yaml config file."""
-        filename = "config.yaml"
-        content = (
-            "github_access_token: aaaaabbbbbccccc12345\n"
-            "github_hostname: ''\n"
-            "github_selected_repos:\n"
-            " - staticdev/test\n"
-        )
-        d = tmp_path
-        p = d / filename
-        p.write_text(content)
-        os_join_path.side_effect = [str(d), str(p)]
-        manager = cm.ConfigManager()
+
+def test_save_config_no_file(tmp_path: Path, mock_os_join_path: MockerFixture) -> None:
+    """It raises AttributeError."""
+    d = tmp_path
+    mock_os_join_path.side_effect = [str(d), str(d / "config.yaml")]
+    manager = cm.ConfigManager()
+    with pytest.raises(AttributeError):
         manager.save_config()
-        yaml_dump.assert_called_once()
+
+
+def test_save_config_empty_file(
+    tmp_path: Path, mock_os_join_path: MockerFixture
+) -> None:
+    """It raises AttributeError."""
+    filename = "config2.yaml"
+    d = tmp_path
+    p = d / filename
+    p.write_text("")
+    mock_os_join_path.side_effect = [str(d), str(p)]
+    manager = cm.ConfigManager(filename)
+    with pytest.raises(AttributeError):
+        manager.save_config()
+
+
+def test_save_config_success(
+    tmp_path: Path,
+    mock_yaml_dump: MockerFixture,
+    mock_os_join_path: MockerFixture,
+) -> None:
+    """It dumps yaml config file."""
+    filename = "config.yaml"
+    content = (
+        "github_access_token: aaaaabbbbbccccc12345\n"
+        "github_hostname: ''\n"
+        "github_selected_repos:\n"
+        " - staticdev/test\n"
+    )
+    d = tmp_path
+    p = d / filename
+    p.write_text(content)
+    mock_os_join_path.side_effect = [str(d), str(p)]
+    manager = cm.ConfigManager()
+    manager.save_config()
+    mock_yaml_dump.assert_called_once()

tests/test_github_manager.py

@@ -5,12 +5,9 @@
 # from git_portfolio import config_manager as cm
 
 
-class TestGithubManager:
-    """GithubManager test class."""
-
-    def test_config_repos_dont_select(self) -> None:
-        """It does nothing."""
-        # config = Mock()
-        # github_manager = ghm.GithubManager(config)
-        # github_manager.config_repos(["staticdev/omg"])
-        pass
+def test_config_repos_dont_select() -> None:
+    """It does nothing."""
+    # config = Mock()
+    # github_manager = ghm.GithubManager(config)
+    # github_manager.config_repos(["staticdev/omg"])
+    pass