Skip to content

Commit

Permalink
user: fix naming of groups additional groups var
Browse files Browse the repository at this point in the history
Signed-off-by: Jakub Sokołowski <jakub@status.im>
  • Loading branch information
jakubgs committed Sep 27, 2023
1 parent 9599fef commit eb6db1b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ The `github_webhook_secret` is generated when configuring the webhook in the rep

The public key associated to `github_webhook_ssh_key` has to be added as a Deploy key in the repository setting.

The user `github_webhook_service_user` can be added to additional group by overriding the list `github_webhook_user_additional_group`.
The user `github_webhook_service_user` can be added to additional group by overriding the list `github_webhook_user_additional_groups`.
4 changes: 1 addition & 3 deletions defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
---
github_webhook_service_user: 'github'
github_webhook_service_user_groups: ['www-data']
github_webhook_service_name: '{{ github_webhook_service_user }}-webhook'
github_webhook_description: 'GitHub Webhook server for {{ github_webhook_service_user }} repos'
# Has to be the UID of Airflow user on the host.
Expand All @@ -26,6 +27,3 @@ github_webhook_dependencies:
# REQUIRED: details of repo to keep updated
#github_webhook_repo_url: ~
#github_webhook_repo_branch: ~

github_wehbook_user_additional_group:
- 'www-data'
8 changes: 4 additions & 4 deletions tasks/user.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@

- name: Create webhook user
user:
name: '{{ github_webhook_service_user }}'
group: '{{ github_webhook_service_user }}'
groups: '{{ github_webhook_user_addtional_group }}'
uid: '{{ github_webhook_service_user_uid }}'
name: '{{ github_webhook_service_user }}'
group: '{{ github_webhook_service_user }}'
groups: '{{ github_webhook_service_user_groups }}'
uid: '{{ github_webhook_service_user_uid }}'
create_home: true
comment: 'Airflow Webhook User'

Expand Down

0 comments on commit eb6db1b

Please sign in to comment.