Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrate fork choice #175

Merged
merged 1 commit into from
Mar 13, 2019
Merged

integrate fork choice #175

merged 1 commit into from
Mar 13, 2019

Conversation

arnetheduck
Copy link
Member

@arnetheduck arnetheduck commented Mar 13, 2019 •
edited
Loading

  • keep track of a finalized block
  • keep track of all justified blocks
  • use naive spec version of LMD ghost
  • cache slot number and a few more things in BlockRef
  • keep track of the latest vote of each validator
  • depend less on the state of node.state (it's a cache, effectively)

@arnetheduck arnetheduck mentioned this pull request Mar 13, 2019
Closed
@Swader
Copy link
Contributor

Swader commented Mar 13, 2019

use naive spec version of LMD ghost

Can you please clarify what is naive about it? Would like to expand a little on it for dev update.

@arnetheduck
Copy link
Member Author

naive because the algorithm is O(N^2) meaning it won't perform at scale. there exist better, more complicated algorithms that we'll invest in later, but this is a minimal correct version, insofar as the spec goes.

@arnetheduck arnetheduck changed the title implement fork choice integrate fork choice Mar 13, 2019
@arnetheduck
implement fork choice
f3d0b20 
* keep track of a finalized block
* keep track of all justified blocks
* use naive spec version of LMD ghost
* cache slot number and a few more things in BlockRef
* keep track of the latest vote of each validator
* depend less on the state of node.state (it's a cache, effectively)
@arnetheduck arnetheduck merged commit b0f4034 into master Mar 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the integrate-fork-choice branch March 13, 2019 22:59
etan-status pushed a commit that referenced this pull request May 12, 2022
@arnetheduck
add explicit gcsafe annotations (fixes #174) (#175)
895fc53 
Seems like a variation of nim-lang/Nim#17369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tersec tersec tersec approved these changes

@mratsim mratsim Awaiting requested review from mratsim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnetheduck @Swader @tersec