Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make release tags #159

Closed
ringabout opened this issue Feb 21, 2021 · 8 comments
Closed

make release tags #159

ringabout opened this issue Feb 21, 2021 · 8 comments

Comments

@ringabout
Copy link

ringabout commented Feb 21, 2021

Please make release tags, otherwise it is more likely to break Nim CI which always requests latest chronos version)

Ref d595e0d

nim-lang/Nim#17130

Thanks!

@timotheecour
Copy link

timotheecour commented Feb 21, 2021

@arnetheduck
Copy link
Member

latest chronos version

I'm not sure why this makes any difference? chronos tests with master are green with Nim in the chronos repo - ie every chronos master commit is as good as a release tag.

@ringabout
Copy link
Author

Not always, I guess?

image

@arnetheduck
Copy link
Member

Github actions is broken for i386 currently, upstream issues, causing partial failures - having a release tag unfortunately wouldn't resolve that.

See actions/runner-images#2951 (comment)

Screenshot from 2021-03-18 16-52-47

@ringabout
Copy link
Author

OK, thanks

@arnetheduck
Copy link
Member

I suspect making release tags isn't really a problem, just don't think they will help with this particular situation.

@ringabout
Copy link
Author

This shows another failed case

nim-lang/Nim#17495

https://github.com/nim-lang/Nim/pull/17495/checks?check_run_id=2182688051

  PASS: [3/42] chroma c                                                     ( 4.13 sec)
  FAIL: chronicles c
  Test "chronicles" in category "nimble-packages"
  Failure: reBuildFailed
  nim c -o:chr -r chronicles.nim
  Hint: used config file '/Users/runner/work/Nim/Nim/config/nim.cfg' [Conf]
  Hint: used config file '/Users/runner/work/Nim/Nim/config/config.nims' [Conf]
  Hint: used config file '/Users/runner/work/Nim/Nim/pkgstemp/chronicles/nim.cfg' [Conf]
  ......................................................
  /Users/runner/.nimble/pkgs/chronos-3.0.0/chronos/asyncmacro2.nim(185, 1) template/generic instantiation from here
  /Users/runner/.nimble/pkgs/chronos-3.0.0/chronos/asyncmacro2.nim(187, 55) Error: can raise an unlisted exception: ref ValueError

@arnetheduck
Copy link
Member

This shows another failed case

this is a chronicles failure though, as an incompatible chronos change was introduced (hence the new chronos major release number)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants