Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Re)add enum support #39

Open
arnetheduck opened this issue Jan 10, 2023 · 0 comments
Open

(Re)add enum support #39

arnetheduck opened this issue Jan 10, 2023 · 0 comments

Comments

@arnetheduck
Copy link
Member

As part of the cleanup in #36, enum suppot was removed to simplify the implementation - support for dealing with protobuf enums should eventually be readded, though it must conform to:

https://developers.google.com/protocol-buffers/docs/proto3#enum and https://developers.google.com/protocol-buffers/docs/proto2#enum respectively - in particular, defaults and unknown values need special handling compared to Nim enum.

In the meantime, enum fields can be encoded as int32/pint or uint32/pint with constants for values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant